Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
aa0011f
feature: port header, footer, settings panel and GA pageviews to React
devin-ai-integration[bot] Nov 11, 2026
a29deb1
feature: port feed list, item rows and paging to React
devin-ai-integration[bot] Nov 11, 2026
61230e0
bug: make settings open/close controls keyboard-accessible buttons
devin-ai-integration[bot] Nov 11, 2026
277fbab
feature: port item details, polls and recursive comments to React
devin-ai-integration[bot] Nov 11, 2026
601912b
feature: port user profile page to React
devin-ai-integration[bot] Nov 11, 2026
985150c
bug: move default fetch stub to test setup to keep routes.test edits …
devin-ai-integration[bot] Nov 11, 2026
c9576c4
Merge remote-tracking branch 'origin/devin/task-2-react-feeds' into d…
devin-ai-integration[bot] Nov 11, 2026
4be1c77
Merge remote-tracking branch 'origin/devin/task-2-react-item' into de…
devin-ai-integration[bot] Nov 11, 2026
70b7a89
Merge remote-tracking branch 'origin/devin/task-2-react-user' into de…
devin-ai-integration[bot] Nov 11, 2026
b75769a
bug: show failed poll options as 0 points and make comment/back contr…
devin-ai-integration[bot] Nov 11, 2026
430c041
bug: make profile back control keyboard-operable
devin-ai-integration[bot] Nov 11, 2026
37ab13b
Merge remote-tracking branches 'origin/devin/task-2-react-item' and '…
devin-ai-integration[bot] Nov 11, 2026
57cd04e
bug: drop placeholder text assertion from shell nav test so it surviv…
devin-ai-integration[bot] Nov 11, 2026
183699f
feature: cut over to React at repo root with PWA, Firebase deploy CI,…
devin-ai-integration[bot] Nov 11, 2026
16099c2
Merge remote-tracking branch 'origin/devin/task-2-react-shell' into d…
devin-ai-integration[bot] Nov 11, 2026
84468b7
bug: scope header styles under #header so .name/.left don't leak into…
devin-ai-integration[bot] Nov 11, 2026
4763c4d
Merge remote-tracking branch 'origin/devin/task-2-react-shell' into d…
devin-ai-integration[bot] Nov 11, 2026
95a9573
Merge remote-tracking branch 'origin/devin/task-2-react-foundation' i…
devin-ai-integration[bot] Nov 11, 2026
b9ef104
bug: avoid duplicate Workbox precache entries for public assets
devin-ai-integration[bot] Nov 11, 2026
84a88d2
bug: re-trigger GitHub Actions CI stuck in runner backlog
devin-ai-integration[bot] Nov 12, 2026
b07b17e
bug: carry stale-response guards and review test fixes into the cutover
devin-ai-integration[bot] Nov 12, 2026
238d9c7
bug: assert jobs hide comment counts and mobile points in the feed test
devin-ai-integration[bot] Nov 12, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: ci

on:
pull_request:
push:
branches: [master]

jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
cache: npm
- run: npm ci
- run: npm run lint
- run: npm run typecheck
- run: npm test
- run: npm run build

deploy:
needs: check
if: github.event_name == 'push' && github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
cache: npm
- run: npm ci
- run: npm run build
- run: npx -y firebase-tools@13 deploy --only hosting --project default --token "$FIREBASE_TOKEN"
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
30 changes: 0 additions & 30 deletions .github/workflows/react-app.yml

This file was deleted.

4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,7 @@ testem.log
# System Files
.DS_Store
Thumbs.db

# vite-plugin-pwa dev output
/dev-dist
*.tsbuildinfo
23 changes: 0 additions & 23 deletions .travis.yml

This file was deleted.

27 changes: 11 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,22 @@
# Contributing

Thank you for your interest in contributing! Please feel free to put up a PR for any issue or feature request.
Even if you have little to no experience with Angular, I'll be more than happy to help. :)
Even if you have little to no experience with React, I'll be more than happy to help. :)

## Setup

1. Fork the repo
2. Clone your fork
3. Make a branch for your feature or bug fix
4. If you don't have Angular CLI installed: `npm install -g angular-cli@latest`
5. `ng init`
6. Type `n` for each file to not overwrite any file changes
7. Run `npm start` and open `localhost:4200` in a browser
8. Work your magic
9. Run `npm run build` or `npm run static-serve` to kick off a production build and make sure nothing is broken
10. To test service worker changes:
* `npm run build` to kick off a fresh build and update the `dist/` directory
* `npm run precache` to generate the service worker file
* `npm run static-serve` to load the application along with the service worker asset using [live-server](https://github.com/tapio/live-server)
11. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README!
12. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`)
13. Push your branch to your fork
14. Create a pull request from your branch on your fork to `master` on this repo
15. Have your branch get merged in! :star2:
4. Run `npm install`, then `npm run dev`, and open `localhost:5173` in a browser
5. Work your magic
6. Run `npm run lint`, `npm run typecheck`, `npm test` and `npm run build` to make sure nothing is broken
7. To test service worker changes:
* `npm run build` then `npm run preview` to test the production build and service worker
8. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README!
9. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`)
10. Push your branch to your fork
11. Create a pull request from your branch on your fork to `master` on this repo
12. Have your branch get merged in! :star2:

If you experience a problem at any point, please don't hesitate to file an issue or send me a message!
18 changes: 8 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</p>

<p align="center">
A progressive Hacker News client built with Angular
A progressive Hacker News client built with React
</p>

<p align="center">
Expand All @@ -14,7 +14,7 @@

<p align="center">
<a href="/CONTRIBUTING.md"><img alt="PRs Welcome" src="https://img.shields.io/badge/PRs-welcome-brightgreen.svg"></a>
<a href="https://travis-ci.org/housseindjirdeh/angular2-hn"><img alt="Build Status" src="https://travis-ci.org/housseindjirdeh/angular2-hn.svg?branch=master"></a>
<a href="https://github.com/COG-GTM/angular2-hn/actions/workflows/ci.yml"><img alt="CI" src="https://github.com/COG-GTM/angular2-hn/actions/workflows/ci.yml/badge.svg"></a>
</p>

---
Expand Down Expand Up @@ -47,7 +47,7 @@ This app uses [Workbox](https://workboxjs.org/) to generate a service worker as

## Manifest

With Chromium based browsers for Android (Chrome, Opera, etc...), Angular 2 HN includes a Web App Manifest that allows you to install to your homescreen.
With Chromium based browsers for Android (Chrome, Opera, etc...), the app includes a Web App Manifest that allows you to install to your homescreen.

<p align="center">
<img src = "http://i.imgur.com/1RaaNkr.png">
Expand All @@ -73,16 +73,14 @@ Feel free to send me feedback on [twitter](https://twitter.com/hdjirdeh) or [fil

## Build process

Note: This project has been ejected (with AOT + production settings) in order to customize Webpack configurations.
The app is built with React, TypeScript and Vite (Node 20+).

- Clone or download the repo
- `npm install`
- `npm start` to run the application with webpack-dev-server or `npm build` to kick off a fresh build and update the output directory (`dist/`)

Note: Any Service Worker changes will not be reflected when you run the application locally in development. To test service worker changes:
- `npm build`
- `npm run precache` to generate the service worker file
- `npm run static-serve` to load the application along with the service worker asset using [live-server](https://github.com/tapio/live-server)
- `npm run dev` to start the dev server on `localhost:5173`
- `npm run lint`, `npm run typecheck` and `npm test` to check changes
- `npm run build` to create a production build in `dist/` (including the service worker generated by `vite-plugin-pwa`)
- `npm run preview` to serve the production build locally, which is the way to test service worker changes

## Contributors

Expand Down
134 changes: 0 additions & 134 deletions angular.json

This file was deleted.

12 changes: 0 additions & 12 deletions browserslist

This file was deleted.

32 changes: 0 additions & 32 deletions e2e/protractor.conf.js

This file was deleted.

23 changes: 0 additions & 23 deletions e2e/src/app.e2e-spec.ts

This file was deleted.

Loading
Loading