Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0fae7f9
feature: MBA-3267 React foundation — react-app/ scaffold, shared libr…
devin-ai-integration[bot] Oct 20, 2026
634904b
bug: MBA-3267 refetch route resources on Back (gcTime 0) and absoluti…
devin-ai-integration[bot] Oct 20, 2026
b20aa36
feature: MBA-3267 per-feature placeholder tests, routes.test mocks fe…
devin-ai-integration[bot] Oct 20, 2026
33a32a1
feature: MBA-3267 document Angular unknown-route URL reset deviation
devin-ai-integration[bot] Oct 20, 2026
fb4db6a
bug: MBA-3267 keep fragment-only hrefs in sanitizeHtml
devin-ai-integration[bot] Oct 20, 2026
5e16a51
feature: MBA-3267 port user profile page to React
devin-ai-integration[bot] Oct 20, 2026
e1cafea
MBA-3267: port app shell, header, settings and footer to React
devin-ai-integration[bot] Oct 20, 2026
0e823b5
MBA-3267: port feeds (FeedList + FeedItem) to React
devin-ai-integration[bot] Oct 20, 2026
0412ad0
feature: MBA-3267 port item details and recursive comments to React
devin-ai-integration[bot] Oct 20, 2026
83b1392
feature: MBA-3267 PWA (vite-plugin-pwa), Playwright e2e, CI and Fireb…
devin-ai-integration[bot] Oct 20, 2026
91ef9b4
bug: MBA-3267 deploy credential check in production job, dotted route…
devin-ai-integration[bot] Oct 20, 2026
a4924c9
bug: MBA-3267 drop JSX spaces Angular strips around comment meta and …
devin-ai-integration[bot] Oct 20, 2026
81e4bda
Merge remote-tracking branch 'origin/devin/mba-3267-shell' into devin…
devin-ai-integration[bot] Oct 20, 2026
195923a
Merge remote-tracking branch 'origin/devin/mba-3267-feeds' into devin…
devin-ai-integration[bot] Oct 20, 2026
b6e8941
Merge remote-tracking branch 'origin/devin/mba-3267-item-details' int…
devin-ai-integration[bot] Oct 20, 2026
fd7230f
Merge remote-tracking branch 'origin/devin/mba-3267-user' into devin/…
devin-ai-integration[bot] Oct 20, 2026
ff46f59
Merge remote-tracking branch 'origin/devin/mba-3267-pwa-e2e-ci' into …
devin-ai-integration[bot] Oct 20, 2026
e82d187
test: MBA-3267 enable the integration-wave Playwright specs against t…
devin-ai-integration[bot] Oct 20, 2026
e8fcec6
MBA-3267: cut over React app to repo root, remove Angular, enable int…
devin-ai-integration[bot] Oct 20, 2026
2daa87d
MBA-3267: root CI/deploy/Firebase config, docs, settings and username…
devin-ai-integration[bot] Oct 20, 2026
95b78f0
MBA-3267: retry failed SW warm-ups; document dropped Universal Analytics
devin-ai-integration[bot] Oct 20, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ root = true
[*]
charset = utf-8
indent_style = space
indent_size = 2
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true

Expand Down
58 changes: 58 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
name: CI

on:
pull_request:
push:

permissions:
contents: read

concurrency:
group: ci-${{ github.ref }}
cancel-in-progress: true

jobs:
build:
name: lint, typecheck, test, build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
cache: npm
- run: npm ci
- run: npm run lint
- run: npm run format:check
- run: npm run typecheck
- run: npm test
- run: npm run build

e2e:
name: e2e (Playwright, prod build + vite preview)
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
cache: npm
- run: npm ci
- name: Install Playwright Chromium
run: npx playwright install --with-deps chromium
- name: Build
run: npm run build
# playwright.config.ts's webServer rebuilds and serves the build with `vite preview`.
- name: Run e2e
run: npm run e2e
- name: Upload Playwright report
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: playwright-report
path: |
playwright-report/
test-results/
retention-days: 14
if-no-files-found: ignore
63 changes: 63 additions & 0 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: Deploy (Firebase Hosting)

on:
push:
branches: [master]
workflow_dispatch:

permissions:
contents: read

concurrency:
group: deploy
cancel-in-progress: false

env:
# Angular's .firebaserc default project; override with the FIREBASE_PROJECT_ID repository variable.
FIREBASE_PROJECT_ID: ${{ vars.FIREBASE_PROJECT_ID || 'angular2-hn' }}

jobs:
deploy:
name: build and deploy
runs-on: ubuntu-latest
# Credentials are checked inside this job so production-environment secrets are visible to the check.
environment: production
env:
FIREBASE_SERVICE_ACCOUNT: ${{ secrets.FIREBASE_SERVICE_ACCOUNT }}
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
steps:
- name: Check Firebase credentials
id: credentials
run: |
if [ -n "$FIREBASE_SERVICE_ACCOUNT" ] || [ -n "$FIREBASE_TOKEN" ]; then
echo "available=true" >> "$GITHUB_OUTPUT"
else
echo "available=false" >> "$GITHUB_OUTPUT"
echo "::notice::FIREBASE_SERVICE_ACCOUNT / FIREBASE_TOKEN secret not set; skipping Firebase deploy."
fi
- if: steps.credentials.outputs.available == 'true'
uses: actions/checkout@v4
- if: steps.credentials.outputs.available == 'true'
uses: actions/setup-node@v4
with:
node-version: 22
cache: npm
- if: steps.credentials.outputs.available == 'true'
run: npm ci
- if: steps.credentials.outputs.available == 'true'
run: npm run lint
- if: steps.credentials.outputs.available == 'true'
run: npm run typecheck
- if: steps.credentials.outputs.available == 'true'
run: npm test
- if: steps.credentials.outputs.available == 'true'
run: npm run build
- name: Deploy to Firebase Hosting
if: steps.credentials.outputs.available == 'true'
run: |
if [ -n "$FIREBASE_SERVICE_ACCOUNT" ]; then
export GOOGLE_APPLICATION_CREDENTIALS="$RUNNER_TEMP/firebase-sa.json"
printf '%s' "$FIREBASE_SERVICE_ACCOUNT" > "$GOOGLE_APPLICATION_CREDENTIALS"
unset FIREBASE_TOKEN
fi
npx --yes firebase-tools@15 deploy --only hosting --project "$FIREBASE_PROJECT_ID" --non-interactive
51 changes: 12 additions & 39 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,46 +1,19 @@
# See http://help.github.com/ignore-files/ for more about ignoring files.
node_modules
dist
dev-dist
coverage
playwright-report
test-results
blob-report
*.tsbuildinfo
*.local
.vite

# compiled output
/dist
/tmp
/out-tsc
# Only exists if Bazel was run
/bazel-out

# dependencies
/node_modules

# profiling files
chrome-profiler-events.json
speed-measure-plugin.json

# IDEs and editors
# IDEs and OS files
/.idea
.project
.classpath
.c9/
*.launch
.settings/
*.sublime-workspace

# IDE - VSCode
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
.history/*

# misc
/.sass-cache
/connect.lock
/coverage
/libpeerconnection.log
npm-debug.log
yarn-error.log
testem.log
/typings

# System Files
npm-debug.log*
.DS_Store
Thumbs.db
11 changes: 11 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
dist
dev-dist
coverage
node_modules
playwright-report
test-results
public
package-lock.json
src/shared/scss/_media.scss
src/shared/scss/_theme_variables.scss
src/shared/scss/_themes.scss
6 changes: 6 additions & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"trailingComma": "es5",
"tabWidth": 4,
"singleQuote": true,
"printWidth": 120
}
23 changes: 0 additions & 23 deletions .travis.yml

This file was deleted.

31 changes: 15 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
# Contributing

Thank you for your interest in contributing! Please feel free to put up a PR for any issue or feature request.
Even if you have little to no experience with Angular, I'll be more than happy to help. :)
Even if you have little to no experience with React, I'll be more than happy to help. :)

## Setup

1. Fork the repo
2. Clone your fork
3. Make a branch for your feature or bug fix
4. If you don't have Angular CLI installed: `npm install -g angular-cli@latest`
5. `ng init`
6. Type `n` for each file to not overwrite any file changes
7. Run `npm start` and open `localhost:4200` in a browser
8. Work your magic
9. Run `npm run build` or `npm run static-serve` to kick off a production build and make sure nothing is broken
10. To test service worker changes:
* `npm run build` to kick off a fresh build and update the `dist/` directory
* `npm run precache` to generate the service worker file
* `npm run static-serve` to load the application along with the service worker asset using [live-server](https://github.com/tapio/live-server)
11. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README!
12. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`)
13. Push your branch to your fork
14. Create a pull request from your branch on your fork to `master` on this repo
15. Have your branch get merged in! :star2:
4. Install Node.js 22.12 or newer, then run `npm ci`
5. Run `npm run dev` and open `http://localhost:4200` in a browser
6. Work your magic (read [MIGRATION.md](MIGRATION.md) for the architecture, SCSS scoping rules and conventions)
7. Make sure nothing is broken:
- `npm run lint && npm run format:check && npm run typecheck && npm test`
- `npm run build` (the only step that compiles the SCSS)
- `npm run e2e` (Playwright against the production build; run `npx playwright install chromium` once)
8. To test service worker changes: `npm run build && npm run preview` and open `http://localhost:4173`
(the service worker is only generated by the production build)
9. Add yourself to the [contributor's list](https://github.com/hdjirdeh/angular2-hn#contributors) in the README!
10. Commit your changes and reference the issue you're addressing (for example: `git commit -am 'Commit message. Closes #5'`)
11. Push your branch to your fork
12. Create a pull request from your branch on your fork to `master` on this repo
13. Have your branch get merged in! :star2:

If you experience a problem at any point, please don't hesitate to file an issue or send me a message!
Loading
Loading