Repository navigation
MBA-3267: migrate angular2-hn from Angular 9 to React (final integration) - #907
Closed
devin-ai-integration[bot] wants to merge 21 commits into
Closed
devin-ai-integration[bot] wants to merge 21 commits into
devin-ai-integration[bot] wants to merge 21 commits into
Conversation
…ary, routing placeholders, CI, MIGRATION.md contract Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…ze HN-relative links in sanitizeHtml Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…ature modules Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…ase hosting for React Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
… params get offline shell, no SPA rewrite for static files Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…back button Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…/mba-3267-react-integration
…/mba-3267-react-integration
…o devin/mba-3267-react-integration
…mba-3267-react-integration
…devin/mba-3267-react-integration
…he real components Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…egration e2e Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
… e2e Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Author
End-to-end UI testing (MBA-3267 final integration)What was tested: React revision Limitations
Results
|
Author
|
Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MBA-3267 — final integration: angular2-hn is now a React 19 app
Jira: MBA-3267
Final wave of the Angular 9 → React migration. Branched from the foundation branch, merged the five Wave 2 branches locally (
--no-ff, no conflicts), then cut over to the repo root.Supersedes
This PR supersedes and replaces all child PRs of this run. Close them, don't merge them:
Duplicate work: open PRs #889 and #896–#900 come from another concurrent run of the same migration. Only one set should land.
What changed
react-app/*moved to the repo root withgit mv(history kept). Angular is gone:src/app/**,main.ts,polyfills.ts,test.ts,environments/,typings.d.ts,styles.scss, oldindex.html/manifest.json,angular.json,ngsw-config.json,karma.conf.js, Protractore2e/,tsconfig.app.json/tsconfig.spec.json(Angular versions),tslint.json,browserslist,yarn.lock, the oldpackage.json, and.travis.yml.package.jsonandpackage-lock.jsoncontain no@angular/*,rxjs,zone.js,karma*,protractorortslint*packages (checked with grep)..travis.ymlis replaced by.github/workflows/ci.ymlat the root. It runs lint, format:check, typecheck, unit tests and build, plus a Playwright e2e job against the production build. Noreact-appworking directory or path filters remain..github/workflows/deploy.ymldeploys to Firebase Hosting on push tomaster(or by manual dispatch). It only runs when theFIREBASE_SERVICE_ACCOUNT/FIREBASE_TOKENsecrets exist, and the check runs inside theproductionenvironment job. It was not run.firebase.jsonkeeps the database rules and hostsdist/. It has a SPA rewrite for routes and extensionless paths (dotted/user/foo.barincluded). Missing static files return 404 instead of index.html. It also carries the PWA cache headers..firebasercanddatabase.rules.jsonare kept.test.fixmeintegration-wave specs are enabled and pass against the real components. Newe2e/integration.spec.tscovers:/user/:idpublic/ngsw-worker.jsis kept. It retires the old Angular service worker for returning visitors.Checks (root)
Firebase hosting emulator (
firebase-tools@14 emulators:start --only hosting, servingdist/):/,/news/2,/item/8863,/user/pg,/user/foo.bar→ 200 index.html/sw.js,/ngsw-worker.js,/manifest.webmanifest,/index.html→no-cache. The manifest is served asapplication/manifest+json./assets/*.jsandworkbox-*.js→max-age=31536000, immutable. Icons →max-age=86400./assets/missing.jsand/missing.png→ 404 (not rewritten)Devin Review follow-up
Documented deviations (kept on purpose)
created_time(node-hnapi/userreturns 404 for everyone).rel="noopener noreferrer".UA-66348622-3) is not ported. Google has shut down UA, so its hits are no longer processed. See MIGRATION.md.errorbodies, null/non-JSON user bodies and invalid ids show an error, never an endless loader.Angular quirks kept for parity
.head-marginnever applies.prefers-color-schemeand is persisted, and it follows live scheme changes.titleFontSizeonly affects feed titles.Known security finding
Snyk:
deepmergecomes in throughworkbox-build(from vite-plugin-pwa) and cannot be fixed upstream yet. It is a build-time dependency only.Devin-Org: engineering