Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions react/e2e/feeds.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
import { expect, test, type Page } from '@playwright/test';
import { FEED_TYPES, PAGE_SIZES, feedHandlers, feedStoryId, feedStoryTitle } from './fixtures/feeds';
import { mockHnApi } from './support/mock-api';

const posts = (page: Page) => page.locator('ol > li.post');

test.describe('feeds', () => {
for (const feedType of FEED_TYPES) {
test(`${feedType}: renders the list and paginates /${feedType}/1 → 2 → 1`, async ({ page }) => {
await mockHnApi(page, feedHandlers);
await page.goto(`/${feedType}/1`);

const feed = page.getByTestId('feed');
await expect(feed).toHaveAttribute('data-feed-type', feedType);
await expect(posts(page)).toHaveCount(PAGE_SIZES[1]);
await expect(page.locator('ol')).toHaveAttribute('start', '1');
await expect(posts(page).first().locator('a.title')).toHaveText(feedStoryTitle(feedType, 1, 0));
await expect(page.locator('.job-header')).toHaveCount(feedType === 'jobs' ? 1 : 0);
await expect(page.getByRole('link', { name: '‹ Prev' })).toHaveCount(0);

await page.getByRole('link', { name: 'More ›' }).click();
await expect(page).toHaveURL(new RegExp(`/${feedType}/2$`));
await expect(feed).toHaveAttribute('data-page', '2');
await expect(posts(page)).toHaveCount(PAGE_SIZES[2]);
await expect(page.locator('ol')).toHaveAttribute('start', '31');
await expect(posts(page).first().locator('a.title')).toHaveText(feedStoryTitle(feedType, 2, 0));
await expect(page.getByRole('link', { name: 'More ›' })).toHaveCount(0);

await page.getByRole('link', { name: '‹ Prev' }).click();
await expect(page).toHaveURL(new RegExp(`/${feedType}/1$`));
await expect(posts(page)).toHaveCount(PAGE_SIZES[1]);
await expect(posts(page).first().locator('a.title')).toHaveText(feedStoryTitle(feedType, 1, 0));
await expect(page.getByRole('link', { name: '‹ Prev' })).toHaveCount(0);
});

test(`${feedType}: shows the error state when the API fails`, async ({ page }) => {
await mockHnApi(page, {});
await page.goto(`/${feedType}/1`);

await expect(page.getByRole('alert')).toContainText(`Could not load ${feedType} stories.`);
await expect(page.getByTestId('feed')).toHaveAttribute('data-feed-type', feedType);
await expect(posts(page)).toHaveCount(0);
});
}

test('jobs rows hide user, points and comments', async ({ page }) => {
await mockHnApi(page, feedHandlers);
await page.goto('/jobs/1');

const first = posts(page).first();
await expect(first.locator('.subtext-laptop')).toHaveText('1 hours ago');
await expect(first.locator('.subtext-laptop a')).toHaveCount(0);
await expect(page.locator('.job-header').getByRole('link', { name: 'Triplebyte' })).toBeVisible();
});

test('clicking a comments link navigates to the item page', async ({ page }) => {
await mockHnApi(page, feedHandlers);
await page.goto('/news/1');

const id = feedStoryId('news', 1, 2);
const second = posts(page).nth(2);
await expect(second.locator('.subtext-laptop')).toContainText('52 points by');
await second.locator('.subtext-laptop').getByRole('link', { name: '2 comments' }).click();

await expect(page).toHaveURL(new RegExp(`/item/${id}$`));
await expect(page.getByTestId('item-details')).toHaveAttribute('data-item-id', String(id));
});

test('internal (ask) titles link to the item page', async ({ page }) => {
await mockHnApi(page, feedHandlers);
await page.goto('/ask/1');

const id = feedStoryId('ask', 1, 0);
await posts(page).first().locator('a.title').click();
await expect(page).toHaveURL(new RegExp(`/item/${id}$`));
});
});
64 changes: 64 additions & 0 deletions react/e2e/fixtures/feeds.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import type { ApiHandler } from '../support/mock-api';

export const FEED_TYPES = ['news', 'newest', 'show', 'ask', 'jobs'] as const;
export type FeedType = (typeof FEED_TYPES)[number];

/** Page 1 is full (30 items → "More" shown); page 2 is partial (→ no "More"). */
export const PAGE_SIZES: Record<number, number> = { 1: 30, 2: 7 };

const FEED_ID_BASE: Record<FeedType, number> = { news: 1000, newest: 2000, show: 3000, ask: 4000, jobs: 5000 };

export function feedStoryId(feedType: FeedType, page: number, index: number): number {
return FEED_ID_BASE[feedType] + (page - 1) * 30 + index + 1;
}

export function feedStoryTitle(feedType: FeedType, page: number, index: number): string {
return `${feedType} story p${page} #${index + 1}`;
}

export function makeFeedPage(feedType: FeedType, page: number) {
const isJob = feedType === 'jobs';
const isAsk = feedType === 'ask';
return Array.from({ length: PAGE_SIZES[page] ?? 0 }, (_, index) => {
const id = feedStoryId(feedType, page, index);
return {
id,
title: feedStoryTitle(feedType, page, index),
points: isJob ? null : 50 + index,
user: isJob ? null : `user${id}`,
time: 1_700_000_000 - id,
time_ago: `${index + 1} hours ago`,
comments_count: isJob ? 0 : index,
type: isJob ? 'job' : isAsk ? 'ask' : 'link',
url: isAsk ? `item?id=${id}` : `https://example.com/${feedType}/${id}`,
domain: isAsk ? undefined : 'example.com',
};
});
}

export function makeItem(id: number) {
return {
id,
title: `Item ${id}`,
points: 10,
user: 'pg',
time: 1_700_000_000,
time_ago: '1 hour ago',
type: 'link',
url: `https://example.com/${id}`,
domain: 'example.com',
content: '',
comments: [],
comments_count: 0,
};
}

export const feedHandlers: Record<string, ApiHandler> = {
...Object.fromEntries(
FEED_TYPES.map((feedType) => [
`/${feedType}`,
(url: URL) => makeFeedPage(feedType, Number(url.searchParams.get('page') ?? '1')),
])
),
'/item/': (url: URL) => makeItem(Number(url.pathname.split('/').pop())),
};
109 changes: 109 additions & 0 deletions react/src/feeds/Feed.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
@use '../styles/media' as *;

// Port of src/app/feeds/feed/feed.component.scss. Angular scoped these to the feed template only,
// so anchor rules target the feed's own links (job header, pagination) rather than story rows.
.feed.main-content {
position: relative;
width: 100%;
min-height: 100vh;
-webkit-transition: opacity 0.2s ease;
transition: opacity 0.2s ease;
box-sizing: border-box;
padding: 8px 0;
z-index: 0;

.job-header a,
.nav a {
text-decoration: none;
font-weight: bold;

&:hover {
text-decoration: underline;
}
}

ol {
padding: 0 40px;
margin: 0;

@media #{$mobile-only} {
box-sizing: border-box;
list-style: none;
padding: 0 10px;
}

li {
position: relative;
-webkit-transition: background-color 0.2s ease;
transition: background-color 0.2s ease;
}
}

.list-margin {
@media #{$mobile-only} {
margin-top: 55px;
}
}

.post {
padding: 10px 0 10px 5px;
transition: background-color 0.2s ease;
border-bottom: 1px solid #cececb;

.itemNum {
color: #696969;
position: absolute;
width: 30px;
text-align: right;
left: 0;
top: 4px;
}
}

.item-block {
display: block;
}

.nav {
padding: 10px 40px;
margin-top: 10px;
font-size: 17px;

a {
@media #{$mobile-only} {
text-decoration: none;
}
}

@media #{$mobile-only} {
margin: 20px 0;
text-align: center;
padding: 10px 80px;
height: 20px;
}

.prev {
padding-right: 20px;

@media #{$mobile-only} {
float: left;
padding-right: 0;
}
}

.more {
@media #{$mobile-only} {
float: right;
}
}
}

.job-header {
font-size: 15px;
padding: 0 40px 10px;

@media #{$mobile-only} {
padding: 60px 15px 25px 15px;
}
}
}
Loading
Loading