Repository navigation
feature: React migration phase 3 — feed list and feed item - #869
Closed
vibhaseshadri-cognition wants to merge 1 commit into
Closed
vibhaseshadri-cognition wants to merge 1 commit into
vibhaseshadri-cognition wants to merge 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…tests (migration phase 3) Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
devin-ai-integration
Bot
force-pushed
the
devin/1791295334-react-phase3-feeds
branch
from
October 6, 2026 14:54
7a2a89a to
52340da
Compare
|
Closing as part of the nightly demo-repo reset — reopen if this demo artifact is still needed. |
devin-ai-integration
Bot
deleted the
devin/1791295334-react-phase3-feeds
branch
October 26, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration phase 3 (stacked on Phase 2 #867): replaces the
Feedplaceholder with a port of Angular'sFeedComponent+ItemComponent.react/src/feeds/Feed.tsx—fetchFeed(feedType, page, signal)in an effect keyed on[feedType, pageNum];AbortControlleraborted in cleanup (unmount/page change), AbortErrors and late responses ignored. Loader → list /ErrorMessage("Could not load {feedType} stories."),window.scrollTo(0, 0)after load, jobs header only forjobs,<ol start={(page-1)*30+1}>withlist-marginexcept on jobs,‹ Prev(page > 1) /More ›(items.length === 30). Rootdiv.main-content[data-testid=feed][data-feed-type][data-page]is rendered in every state.react/src/feeds/FeedItem.tsx— externala.title(target/rel only whenopenLinkInNewTab) +(domain), or internal/item/:idlink;.subtext-palm/.subtext-laptopblocks with user/points/comments hidden fortype === 'job';margin-bottom: {listSpacing}px, titlefont-size: {titleFontSize}px.Feed.scss/FeedItem.scss, nested under.feed/.feed-item.Feed.test.tsx,FeedItem.test.tsx(mockedhackernewsApi, shared factorysrc/test/feedStories.ts),e2e/feeds.spec.ts+e2e/fixtures/feeds.ts(all 5 feeds: list +/x/1 → /x/2 → /x/1, error state per feed, jobs rows, comments link →/item/:id, ask title →/item/:id).Parity notes (intentional deviations)
start) until the new page arrived and never clearederrorMessage. React resets to loading per request so the list number/nav never go stale and an earlier error doesn't stick.hasUrltolerates a missingurl(item.url?.startsWith('http')); Angular would throw onundefined.NaN).bold, hover underline) are scoped to.job-header a/.nav a, matching Angular's view encapsulation where they didn't reach story rows.feedclass (main-content feed) to scope SCSS without bleeding into ItemDetails/UserProfile, which also use.main-content.*ngIf="feedType !== 'new'"on the<ol>dropped (never false).Coverage (
npm test)Locally:
format:check,lint,typecheck,test(107 passed),build,e2e(23 passed) all green.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/f1105e215c184c1eab62a12bc7f0b06e
Open in Devin Desktop: https://app.devin.ai/desktop/session/f1105e215c184c1eab62a12bc7f0b06e?variant=devin
Requested by: @vibhaseshadri-cognition