fix: Handle GitHub API artifact propagation delay #976
+128
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a build completes successfully but the artifact isn't immediately visible via the GitHub API (due to propagation delay), the test was incorrectly marked as a permanent failure. This caused tests to fail with "Artifact not found" even though the artifact existed. Changes: - Add 5-minute grace period in _diagnose_missing_artifact(): if a build completed recently but artifact isn't visible, treat as retryable instead of permanent failure - Add retry logic (3 attempts with 2s backoff) to mark_test_failed() for GitHub status updates to prevent stuck "pending" status - Add tests for new retry behavior Fixes issue where PR #1913 showed "Tests queued" on GitHub but "An error occurred" on Sample Platform - the artifact was uploaded at 07:40:57 but the test ran at 07:41:04 (7 seconds later) before the API reflected the new artifact. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
cfsmp3
added a commit
that referenced
this pull request
Dec 27, 2025
The final GitHub status update in progress_type_request() was not using retry logic, causing tests to complete but remain stuck in "pending" state on GitHub if the status update failed (e.g., due to rate limiting or network issues). This is the same fix applied to mark_test_failed() in PR #976, now applied to the normal test completion path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a GitHub Actions build completes, there can be a brief delay before the artifact is visible via the GitHub API. If the Sample Platform cron runs during this window:
find_artifact_for_commit()doesn't find artifact (API propagation delay)_diagnose_missing_artifact()sees build succeeded → marks as permanent failureThis was observed on CCExtractor/ccextractor#1913.
Solution
Grace period for recently-completed builds: If a build completed within the last 5 minutes but artifact isn't visible, treat as retryable instead of permanent failure
Retry logic for GitHub status updates: Use
retry_with_backoff()(3 attempts, 2s initial backoff) when updating GitHub status inmark_test_failed()to handle transient API failuresTest plan
test_recently_completed_build_is_retryable- verifies builds completed 1 minute ago are retryabletest_old_completed_build_is_not_retryable- verifies builds completed 10 minutes ago are not retryabletest_mark_test_failed_uses_retry_for_github- verifies retry logic is used for GitHub status updatesTestDiagnoseMissingArtifacttests passTestMarkTestFailedImprovedtests pass🤖 Generated with Claude Code