fix: Add retry logic to final GitHub status update #977
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final GitHub status update in progress_type_request() was not using retry logic, causing tests to complete but remain stuck in "pending" state on GitHub if the status update failed (e.g., due to rate limiting or network issues). This is the same fix applied to mark_test_failed() in PR #976, now applied to the normal test completion path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a test finishes (either successfully or with failures), the Sample Platform updates the GitHub commit status. However, if this API call fails (rate limiting, network issues, etc.), the status remains stuck in "pending" showing "Tests queued" on GitHub even though the test actually completed.
This was observed on CCExtractor/ccextractor#1913 where the Linux test completed with results visible on the Sample Platform, but GitHub still showed "Tests queued".
Solution
Apply the same retry logic we added to
mark_test_failed()in PR #976 to the normal test completion path inprogress_type_request().The status update now uses
retry_with_backoff()with 3 retries and 2-second initial backoff.Test plan
test_progress_reporter_finish_typepasses🤖 Generated with Claude Code