Swift 5 and Swift Package Manager#698
Open
joshbillions wants to merge 11 commits intoC4Labs:masterfrom
joshbillions:master
Open
Swift 5 and Swift Package Manager#698joshbillions wants to merge 11 commits intoC4Labs:masterfrom joshbillions:master
joshbillions wants to merge 11 commits intoC4Labs:masterfrom
joshbillions:master
Conversation
alejandro-isaza
requested changes
Nov 29, 2019
C4/Core/Color.swift
Outdated
| /// Initializes a UIColor object from a Color object. | ||
| /// - parameter color: The C4 color object. | ||
| public convenience init?(_ color: Color) { | ||
| convenience init?(_ color: Color) { |
Member
There was a problem hiding this comment.
Please use spaces for indentation.
Author
There was a problem hiding this comment.
Oops. Moved 'em back to spaces.
C4/UI/AudioPlayer.swift
Outdated
| public init?(_ name: String) { | ||
| do { | ||
| try AVAudioSession.sharedInstance().setCategory(AVAudioSessionCategoryPlayback) | ||
| try AVAudioSession.sharedInstance().setCategory(.playback) |
Member
There was a problem hiding this comment.
All these indentation changes need to be reverted.
Author
There was a problem hiding this comment.
Oops. Moved 'em back to spaces.
Member
|
I still see a lot to tabs and other spacing changes... |
Author
|
Ok. I think I've got everything now. |
C4/UI/AudioPlayer.swift
Outdated
| public init?(_ name: String) { | ||
| do { | ||
| try AVAudioSession.sharedInstance().setCategory(AVAudioSessionCategoryPlayback) | ||
| try AVAudioSession.sharedInstance().setCategory(AVAudioSession.Category(rawValue: convertFromAVAudioSessionCategory(AVAudioSession.Category.playback))) |
Member
There was a problem hiding this comment.
This can all be just .playback
C4/UI/AudioPlayer.swift
Outdated
| // Helper function inserted by Swift 4.2 migrator. | ||
| private func convertFromAVAudioSessionCategory(_ input: AVAudioSession.Category) -> String { | ||
| return input.rawValue | ||
| } |
alejandro-isaza
approved these changes
Nov 30, 2019
|
Hello. Any updates with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Swift 5 and Swift Package Manager