Closed
Conversation
added 6 commits
March 31, 2020 13:42
bump swift bump test apps target swift version
Without knowing too much of the implemenation I chose the the portriat case as a kind of fallback
mltbnz
force-pushed
the
adopt-swift5-changes
branch
from
95e3833 to
1e25f33
Compare
Author
|
Does the Xcode version also need to be bumped up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically #698 but without the SPM support since I think that could be a separate PR.
Since the a.m. PR seems to be stale or the branch was not existing anymore I wanted to add this here.