fix(ui): avoid sidebar stall from sync network on page show (#129) - #130
Closed
Detritalw wants to merge 2 commits into
Closed
fix(ui): avoid sidebar stall from sync network on page show (#129)#130Detritalw wants to merge 2 commits into
Detritalw wants to merge 2 commits into
Conversation
PassPort avatar no longer blocks the UI thread: read local cache first, download in the background, and notify via passPortAvatarChanged. Home activity/server refresh uses a 5-minute TTL and skips localmod; remote info/server requests get 5s timeouts so offline/slow nets cannot freeze navigation.
This comment has been minimized.
This comment has been minimized.
Detritalw
marked this pull request as draft
July 25, 2026 23:00
Harden home remote refresh with in-flight guards and success-only TTL so failed requests can retry. Cache launch items briefly, avoid force-scanning Java on every Settings open, defer home network/plugin work with Qt.callLater, and ignore stale avatar downloads after account switch.
Detritalw
marked this pull request as ready for review
July 26, 2026 02:47
This comment has been minimized.
This comment has been minimized.
Member
Author
|
冲突过大，待我重写。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassPort avatar no longer blocks the UI thread: read local cache first, download in the background, and notify via passPortAvatarChanged. Home activity/server refresh uses a 5-minute TTL and skips localmod; remote info/server requests get 5s timeouts so offline/slow nets cannot freeze navigation.
close #129
Not tested yet