fix(ui): 修复侧边栏切换主页卡顿 (#129) - #131
Open
Bloriko wants to merge 5 commits into
Open
Conversation
NavigationView recreates pages on every sidebar click. Defer Home network work, add TTL/in-flight guards for activity/server data, cache launch items briefly, and give remote requests timeouts so offline/slow nets cannot pile up threads and stall navigation. close #129
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
- DownloadDialog: non-modal + no dim overlay so navigation works during downloads; ListModel in-place updates; full status_text, stopwatch, speed/ETA/size, max threads; signal-driven progress patches - VersionNameDialog / SelectVersionDialog: raise heights so inputs and combos are not clipped by RinUI padding/footer - Download page: poll only when StackView-active; stable status ListModel with detailed status/speed lines - download_manager: throttle QML progress signals and prune less often to reduce main-thread stalls when switching pages
Rebrand the Resource Pack Editor's AI assistant from "BLRPE Copilot" to "Blora Agent", aligning with the launcher's existing agent brand name, and switch its avatar from icon/BLRPE.png to icon/Bloriko.jpg. - QML: AgentTab avatar/source, editor tab label, notification strings, Settings notification label and AI provider description - Backend: system prompt self-identification, OS notification titles, permission label, notification doc, BLAPI validation messages - i18n: update keys/values across all 5 lang files - Docs: plugin specs, plugin developer guide, wiki pages
Replace RinUI Frame+clip and anchors.fill MouseArea height trap with a content-sized Rectangle (min height 88), always show progress/status rows, and rebuild the status ListModel so active downloads are visible.
- Bump RinUI: Icon circular mask, NavigationItem wiring, safePush coalescing + watchdog, TitleBar/NavigationBar title leading width - main.qml: passport nav item sets circular/radius/cropToFit for avatar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigationView每次侧边栏切页都会StackView.replace销毁并重建页面，Home.qml的Component.onCompleted会反复调用refreshActivityInfo/refreshServerInfo，再叠加主线程getLaunchItems扫盘，造成侧边栏卡顿。Qt.callLater下一帧localmod跳过打网/api/info与查服请求统一 timeout=5，避免慢网线程堆积forceRefresh=trueWindows（头像异步契约沿用主干，不回退）。close #129
Test plan
python3 -m unittest test_runtime_regressions -v通过（含新增 关于侧边栏点击时发生的卡顿的性能问题 #129 断言）/api/info与查服 API