Skip to content

ci: name the release jar SetHomes-<x>.jar to match v1 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmalhotra merged 1 commit into from
Aug 18, 2026
Merged

ci: name the release jar SetHomes-<x>.jar to match v1 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
if: steps.plan.outputs.release == 'true' && !inputs.dry_run
env:
NEXT: ${{ steps.plan.outputs.next }}
run: cp "target/SetHomesTwo-$NEXT.jar" "SetHomes.V$NEXT.jar"
run: cp "target/SetHomesTwo-$NEXT.jar" "SetHomes-$NEXT.jar"

- name: Publish to BukkitDev
if: steps.plan.outputs.release == 'true' && !inputs.dry_run
Expand All @@ -174,8 +174,8 @@ jobs:
VERSION: ${{ steps.plan.outputs.next }}
run: |
NOTES=$(bash scripts/release.sh notes --readme README.md --version "$VERSION")
gh release create "v$VERSION" "SetHomes.V$VERSION.jar" \
--title "Set Homes V$VERSION" \
gh release create "v$VERSION" "SetHomes-$VERSION.jar" \
--title "SetHomes V$VERSION" \
--notes "$NOTES"

# An issue closes when the commit that fixed it is contained in the commit
Expand Down
4 changes: 2 additions & 2 deletions scripts/publish-bukkitdev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ CHANGELOG=$(bash "$SCRIPT_DIR/release.sh" notes --readme README.md --version "$V
# backslashes and newlines.
METADATA=$(jq -n \
--arg changelog "$CHANGELOG" \
--arg displayName "Set Homes V$VERSION" \
--arg displayName "SetHomes V$VERSION" \
--argjson gameVersions "$GAME_VERSIONS" \
'{
changelog: $changelog,
Expand All @@ -64,7 +64,7 @@ METADATA=$(jq -n \
RESPONSE=$(curl -sS -w '\n%{http_code}' -X POST "$API/projects/$PROJECT_ID/upload-file" \
-H "X-Api-Token: $CURSEFORGE_TOKEN" \
--form-string "metadata=$METADATA" \
-F "file=@SetHomes.V$VERSION.jar")
-F "file=@SetHomes-$VERSION.jar")

BODY=$(echo "$RESPONSE" | head -n -1)
CODE=$(echo "$RESPONSE" | tail -n 1)
Expand Down
4 changes: 2 additions & 2 deletions scripts/test-publish-bukkitdev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,13 @@ else
fi

DISPLAY_NAME=$(printf '%s' "$METADATA" | jq -r '.displayName // ""' 2>/dev/null)
if [ "$DISPLAY_NAME" = "Set Homes V9.9.9" ]; then
if [ "$DISPLAY_NAME" = "SetHomes V9.9.9" ]; then
pass "names the file after the version"
else
fail "names the file after the version" "got: $DISPLAY_NAME"
fi

if has_arg "file=@SetHomes.V9.9.9.jar"; then
if has_arg "file=@SetHomes-9.9.9.jar"; then
pass "uploads the versioned jar"
else
fail "uploads the versioned jar" "args were: $(args_summary)"
Expand Down
Loading