ci: name the release jar SetHomes-<x>.jar to match v1 - #70
Merged
Conversation
The files page on listing 312833 has used one convention since 1.2.4: the jar is SetHomes-<version>.jar and its display name is SetHomes V<version>. 2.0.0 would have arrived as SetHomes.V2.0.0.jar under "Set Homes V2.0.0", which reads as a different plugin sitting on top of the v1 downloads. The GitHub Release asset and title follow the same strings, so the two places a server owner can download from agree. The hyphen also avoids GitHub normalizing a space in an asset name. The Maven artifact is untouched: target/SetHomesTwo-<version>.jar is still what the build produces and what ../Spigot/start.bat copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BukkitDev files page for listing 312833 has used one naming convention since
1.2.4, confirmed against the live listing:
SetHomes-1.3.0.jarSetHomes V1.3.0SetHomes.V2.0.0.jarSet Homes V2.0.0Both strings now follow v1, so v2 arrives as the next file in the same series
rather than looking like a different plugin. This also matches what the design
doc asked for (
docs/superpowers/specs/2026-08-15-set-homes-listing-consolidation-design.mdline 178 specifies
SetHomes V<version>); the implementation had drifted to"Set Homes" with a space.
Changes:
.github/workflows/release.ymlrenames the build output toSetHomes-<version>.jarand publishes the GitHub Release with that asset andthe title
SetHomes V<version>.scripts/publish-bukkitdev.shuploads the same filename with display nameSetHomes V<version>.scripts/test-publish-bukkitdev.shasserts the new strings.The hyphen also sidesteps GitHub normalizing a space in a release asset name.
The Maven artifact is unchanged:
target/SetHomesTwo-<version>.jaris still whatthe build produces and what
../Spigot/start.batcopies, so the dev loop isunaffected.
No changeset:
.github/andscripts/are both exempt inscripts/require-changeset.sh, and nothing here ships inside the jar.2.0.0 itself is being uploaded by hand, so this first applies to the release
after it.