fix(reset): stop displaying internal entropy - #336
Draft
BitHighlander wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security invariant
Production firmware must never render or return the 32-byte internal entropy used as seed pre-image material.
Change
Internal EntropyOLED confirmation path from resetdisplay_randomfrom the internal reset APIBefore this change, a host could set
ResetDevice.display_random, supply the external entropy, and reconstructSHA256(internal_entropy || external_entropy)after observing the screen once.Validation
make xunitexecution: firmware 388/388, board 2/2, crypto 4/4, Pallas constant-time 7/7display_randomand noInternal Entropyscreen remainsfirmware.keepkey.bin: 649,748 bytes)firmware.keepkey.bin: 361,076 bytes)Compatibility
The protobuf schema is unchanged. Hosts that still send
display_random=truereceive normal reset behavior without an entropy screen.Hardware check
On an uninitialized test device, send otherwise-identical reset requests with
display_randomfalse and true. Both must follow the same PIN/backup flow, and neither may display entropy bytes.The wider hardening sequence and acceptance gates are tracked in #334.