feat(storage): version PIN KDF hardening - #335
Draft
BitHighlander wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security goal
Restore a material offline work factor for the user PIN. Storage v16 reduced the production PBKDF2 count used for the PIN wrapping key from 100,000 to 10.
Change
pin_kdf_v2selector in flags bit 20Evidence
make xunitexecution: firmware 390/390, board 2/2, crypto 4/4, Pallas constant-time 7/7firmware.keepkey.bin: 650,196 bytes)firmware.keepkey.bin: 361,588 bytes)Draft blockers
Do not merge for production until all of these are resolved:
The design and release ordering are documented in
docs/security/pin-kdf-v19-migration.md; the wider hardening sequence and anti-rollback RFC are in #334.