Android client. Add some options to channel prop by amirmahdifard · Pull Request #3320 · BearWare/TeamTalk5

amirmahdifard · 2026-06-07T19:52:11Z

enable fixed audio volume for all users and its slider
stream timeout timers
voice stream max duration
media file stream max duration

amirmahdifard · 2026-06-09T14:36:58Z

small and nice improvements. Thanks.

amirmahdifard · 2026-06-09T16:36:43Z

is 500 ms even used? So What should I do, How do I calculate the sliders to become what you want?

amirmahdifard · 2026-06-09T16:47:53Z

@bear101 by the way, when will you decide to merge all my pull requests?

amirmahdifard · 2026-06-10T17:31:05Z

@bear101 I incorrectly used seekbar for this case, but seekbar is not good and it's limited, but I used edit text like disk quota and max users text boxes also like desktop qt client, so now user is free to enter any number. I also added the (msec) hint so user knows that they should enter in mili seconds, like disk quota (kbites) hint

bear101 · 2026-06-14T05:01:29Z

@hwangsihu did you test it on your Android device?

hwangsihu · 2026-06-14T05:57:57Z

Yeah, It's working fine.

hwangsihu · 2026-06-14T06:03:50Z

Ah, I missed something. It's an issue where fixed volumes are enabled by default. I'll fix this.

hwangsihu · 2026-06-14T06:23:38Z

While editing, I made a few adjustments to match qtTeamTalk.

amirmahdifard · 2026-06-14T07:51:28Z

@bear101 why are you asking @hwangsihu to test my changes in his android device? you think I don't test my own changes when i'm opening a pull request? please respect contributors who are taking their times to work on your project. My pull requests are open here more than 3 or 4 weeks now, while my pull request I sent to nvda repozitory has been merged less than 24 hours. You don't see all my hevvy work on teamtalk android in the passed?

hwangsihu · 2026-06-14T08:27:18Z

I don't think there's any reason to delay. Please approve any PRs you think can now be merged. I almost fixed the problematic code in Amir's PRs.

And this is the master branch, not the production branch. There is no perfect person in this world. It's natural for problems to arise, and it's up to someone to fix them whenever they are discovered.

According to Amir's claims, he lives in Iran and is currently suffering from an internet blockade. Despite struggling with VPN issues, he hasn't stopped contributing to TeamTalkAndroid. I think we need to respect these passionate developers.

amirmahdifard · 2026-06-14T08:40:05Z

@hwangsihu true. Actually, as you even see, my code didn't have any problem they were working fine, but @bear101 requested a bit of stile change. For example, replacing number 1000 with a menu item baced url, and renamings like that but everything I post, I test them actually i'm so sensitiv about my code. Sometimes I need to compile a code 100 times and test them to make them work. And about my life status, the troo fakt is that people from other cuntrys with easy lives can't understand this. How a person from denmark can understand a person's problems in iran? that's why they don't care

amirmahdifard · 2026-06-17T08:52:12Z

@bear101 @hwangsihu please also merge my other pull requests they are all ready for review.

- Remove unused AdapterView import - Fix the column-0 indentation of the fixed-volume visibility lines and split the two-statements-per-line setEnabled/setVisibility calls - Replace the leftover "Medium Text" placeholder in the voice/media duration labels with an empty string Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

seekbars were incorrect choise for these. Now users are able to enter any number they want in miliseconds

- Rename the fixed-volume slider label "Volume" to "Volume level" - Fix the default channel audio config so fixed volume (AGC) is off by default with gain level 9600, matching qtTeamTalk/TeamTalkClassic. Corrected in the SDK AudioConfigConstants (Java) and mirrored in the .NET binding so all clients share the same defaults. - Take voice/media stream timeouts in seconds (1-decimal) like the qtTeamTalk channel dialog, so sub-second values are preserved Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Outdated

amirmahdifard · 2026-06-24T07:58:00Z

@bear101 when will you press the merge button for this pr?

bear101 · 2026-06-27T05:50:32Z

@hwangsihu @amirmahdifard here's an AI answer to how to write good git commit messages:

Writing a good Git commit message is essential for maintaining a clear and useful project history. Here’s a concise guide to crafting effective commit messages:

Structure of a Good Commit Message

Subject Line (Title)

Keep it short: 50 characters or fewer.
Use imperative mood: Start with a verb (e.g., "Fix bug", "Add feature").
Capitalize the first letter.
No period at the end.

Example:

Add user authentication middleware

Body (Optional but Recommended for Complex Changes)

Separate from the subject line with a blank line.
Wrap at 72 characters for readability.
Explain the "what" and "why": Focus on the reasoning behind the change, not just the change itself.
Use bullet points or lists if needed for clarity.

Example:

Add user authentication middleware

- Implement JWT-based authentication for API endpoints
- Resolves issue #123 where users could access protected routes without logging in

bear101 · 2026-06-27T05:57:41Z

@amirmahdifard now please fix your commit messages using these rules of thumb with regard to commit messages.

Also don't use the "Android client" prefix in the subject. If you want to know what code is changed you can look at the files. Use the --name-only option to git log.

bear101 · 2026-06-27T05:58:28Z

@hwangsihu aren't the 4 commits overwriting the same code? It doesn't make sense to write changes that are overwritten in later commits.

amirmahdifard · 2026-06-28T09:59:19Z

@bear101 it is impossible to edit a commit message that is already sent. I will do in my new commits from now on. And how you like the title of the pr to look like?

Android client should use TeamTalkConstants.DEFAULT_CHANNEL_AUDIOCONFIG_LEVEL

bear101 · 2026-06-30T20:17:31Z

+        TextView fixvolLabel = findViewById(R.id.fixvolumeLabel);
+        SeekBar fixvolume = findViewById(R.id.fixvolumeSeekBar);
+
+        fixvolume.setMax((SoundLevel.SOUND_GAIN_MAX - SoundLevel.SOUND_GAIN_MIN) / 1000);


This is where you should assign TeamTalkConstants.DEFAULT_CHANNEL_AUDIOCONFIG_LEVEL

@amirmahdifard isn't this correct?

Revert DEFAULT_AGC_GAINLEVEL to 8000

amirmahdifard · 2026-06-30T20:28:31Z

@bear101 done. i merged your pr which you opened for this branch and your changes are now here. I will merge your prs whenever you open pr to my branches

bear101 · 2026-06-30T20:33:28Z

@amirmahdifard please clean up the commits. There should be one commit for /Library and one following for /Client

git rebase -i origin/master

amirmahdifard · 2026-06-30T21:48:01Z

@bear101 I don't want to touch this branch anymore because @hwangsihu messed up this branch, so I don't know what is going on in this branch anymore. I'm now only responceable for my pause stream and rightswork branches. Thanks so @hwangsihu fix this branch because you touched it.

This will make a squash commit treat the values as unchanged and thereby keeps existing compatibility

Revert to DEFAULT_AGC_ENABLE to true

amirmahdifard · 2026-07-02T18:01:02Z

@bear101 i've merged your pull request, and also I've enabled this branch access, so you can work on it directly.

bear101 · 2026-07-02T19:18:56Z

+        TextView fixvolLabel = findViewById(R.id.fixvolumeLabel);
+        SeekBar fixvolume = findViewById(R.id.fixvolumeSeekBar);
+
+        fixvolume.setMax((SoundLevel.SOUND_GAIN_MAX - SoundLevel.SOUND_GAIN_MIN) / 1000);


@amirmahdifard isn't this correct?

amirmahdifard · 2026-07-02T21:38:01Z

@bear101 yes. fixvolume.setMax((SoundLevel.SOUND_GAIN_MAX - SoundLevel.SOUND_GAIN_MIN) / 1000); works fine up on my tests when I was implementing this feature at first. But now I haven't tested this pr since a long time. But the last time I tested it and pushed to github It was correct. Do you want me to delete this completely and implement this again, or you want to work on the current implementation and add this one?

bear101 · 2026-07-04T06:05:50Z

The "create channel activity" looks really bad with these changes. The Audio Configuration options should be moved to a sub-activity (like Audio Codec configuration). The main "create channel activity" should only contain a minimum set of information.

amirmahdifard · 2026-07-05T10:42:04Z

But when I asked you one time, You told me to Add it to the main activity. Also, Audio codec configuration is devided by tabs, opuce, speeks, speeks vbr etc, but fixed audio volume for all users option is a globel option. So I don't understand what you mean or how you want to desighn this. This pr just adds 3 new controles to channel prop activity.

amirmahdifard requested review from a team, bear101, beqabeqa473, hwangsihu and poretsky as code owners June 7, 2026 19:52

bear101 requested changes Jun 9, 2026

View reviewed changes

Comment thread Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/ChannelPropActivity.java Outdated

amirmahdifard requested a review from bear101 June 10, 2026 17:27

hwangsihu force-pushed the channeloptions branch from 6399abd to da652a9 Compare June 14, 2026 00:02

hwangsihu approved these changes Jun 14, 2026

View reviewed changes

bear101 requested changes Jun 14, 2026

View reviewed changes

Comment thread Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/ChannelPropActivity.java Outdated

hwangsihu force-pushed the channeloptions branch from c3cb0e4 to 500796d Compare June 14, 2026 06:21

hwangsihu force-pushed the channeloptions branch from 500796d to c13c6da Compare June 14, 2026 06:24

bear101 reviewed Jun 14, 2026

View reviewed changes

Comment thread Library/TeamTalkJNI/src/dk/bearware/Channel.java Outdated

bear101 previously requested changes Jun 14, 2026

View reviewed changes

Comment thread Library/TeamTalkJNI/src/dk/bearware/Channel.java Outdated

hwangsihu force-pushed the channeloptions branch 2 times, most recently from fd0f340 to c68d504 Compare June 14, 2026 07:01

amirmahdifard requested a review from bear101 June 17, 2026 13:07

Added missing options to channel prop

90b526f

hwangsihu and others added 3 commits June 19, 2026 18:39

replaced with edit boxes

66bc38d

seekbars were incorrect choise for these. Now users are able to enter any number they want in miliseconds

hwangsihu force-pushed the channeloptions branch from c68d504 to ce2bd0f Compare June 19, 2026 09:39

hwangsihu added this to the TeamTalk v5.23 milestone Jun 24, 2026

hwangsihu changed the title ~~Android client. Added the missing options to channel prop~~ Android client. Add some options to channel prop Jun 28, 2026

amirmahdifard mentioned this pull request Jun 29, 2026

Added my name to teamtalk android #3314

Closed

Revert DEFAULT_AGC_GAINLEVEL to 8000

94cc909

Android client should use TeamTalkConstants.DEFAULT_CHANNEL_AUDIOCONFIG_LEVEL

bear101 reviewed Jun 30, 2026

View reviewed changes

Merge pull request #2 from BearWare/audiocfg-android

7c30dcc

Revert DEFAULT_AGC_GAINLEVEL to 8000

bear101 marked this pull request as draft July 1, 2026 06:52

bear101 and others added 2 commits July 2, 2026 18:50

Revert to DEFAULT_AGC_ENABLE to true

c657935

This will make a squash commit treat the values as unchanged and thereby keeps existing compatibility

Merge pull request #3 from BearWare/revert-agc-default

23e1282

Revert to DEFAULT_AGC_ENABLE to true

bear101 requested changes Jul 2, 2026

View reviewed changes

Uh oh!

Conversation

amirmahdifard commented Jun 7, 2026

Uh oh!

amirmahdifard commented Jun 9, 2026

Uh oh!

Uh oh!

amirmahdifard commented Jun 9, 2026

Uh oh!

amirmahdifard commented Jun 9, 2026

Uh oh!

amirmahdifard commented Jun 10, 2026

Uh oh!

bear101 commented Jun 14, 2026

Uh oh!

hwangsihu commented Jun 14, 2026

Uh oh!

hwangsihu commented Jun 14, 2026

Uh oh!

Uh oh!

hwangsihu commented Jun 14, 2026

Uh oh!

Uh oh!

Uh oh!

amirmahdifard commented Jun 14, 2026

Uh oh!

hwangsihu commented Jun 14, 2026

Uh oh!

amirmahdifard commented Jun 14, 2026

Uh oh!

amirmahdifard commented Jun 17, 2026

Uh oh!

amirmahdifard commented Jun 24, 2026

Uh oh!

bear101 commented Jun 27, 2026

Uh oh!

bear101 commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bear101 commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amirmahdifard commented Jun 28, 2026

Uh oh!

bear101 Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bear101 Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

amirmahdifard commented Jun 30, 2026

Uh oh!

bear101 commented Jun 30, 2026

Uh oh!

amirmahdifard commented Jun 30, 2026

Uh oh!

amirmahdifard commented Jul 2, 2026

Uh oh!

bear101 Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

amirmahdifard commented Jul 2, 2026

Uh oh!

bear101 commented Jul 4, 2026

Uh oh!

amirmahdifard commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bear101 commented Jun 27, 2026 •

edited

Loading

bear101 commented Jun 27, 2026 •

edited

Loading

bear101 Jun 30, 2026 •

edited

Loading