Added my name to teamtalk android

[amirmahdifard]

No description provided.

[hwangsihu]

You cannot do that if you are not a member of the organization.

[amirmahdifard]

@hwangsihu please look at the teamtalk project history. Even before you come and start contributing to teamtalk, Look at my merged pull requests history, More than 40 50 changes to teamtalk android, in 5.18, 5.19, a bit before it as wel, I've mostely refactored the entire teamtalk android to do my prepration to add the new features even more, And I started again now. So how Is that you are the member and i'm not? I don't understand how. Am I a developer and contributor of teamtalk android or not? if not then why i'm even working for teamtalk android?

[hwangsihu]

It is not me, but the system that refuses for a non-organizational member to become the code owner.

[hwangsihu]

Don't complain to me; instead, ask @bear101 to invite you to the organization.

[amirmahdifard]

@hwangsihu did he invite you? if he was the one who invited you then he should invite me as well because i'm a contributor member as well. Even you can see my name in teamtalk android developers names list

[amirmahdifard]

@bear101 please also invite me thanks.

[computertech1012]

Hi,
I am a little bit new here, but it does seam to me that @amirmahdifard has contributed a lot to the Android client. I honestly feel like he doesn't get enough credit for his work. Maybe there is something I am missing, but he has been working TeamTalk Android a long time. Unless I am missing something please everyone lets work together on this TeamTalk project.
Thanks for reading!

[amirmahdifard]

@computertech1012 yes i'm working for so long time, but some people doesn't understand sadly, and some of them even blame me for anything. Also, my cuntry state is so hard

[hwangsihu]

If you join the organization, we could merge.

[amirmahdifard]

@hwangsihu why did you closed this? reopen it.

[computertech1012]

Hi,
I am curious to know why this was closed? IS there some aditional tests that need to be done? Or, is this feature not planned.
Thanks for reading!

[hwangsihu]

Hi,

I am curious to know why this was closed? IS there some aditional tests that need to be done? Or, is this feature not planned.

Thanks for reading!

@computertech1012, check the comments above. He is not a organization member so this feature is not work. Thanks.

[computertech1012]

Hi,
@hwangsihu I understand that. But, this person has contributed a lot to the Android client. I do not understand why @bear101 wants to add surten people to the organization, but yet someone who takes his entire day to contribute to the Android client does not get to be added?
Sorry, but @amirmahdifard has spent a lot of time contributing to the client. I think he deserves more respect.
Thanks for reading!

[hwangsihu]

I admit it, too. His PR was neglected. He had added a Change Log, and the code was mostly fine, but it wasn't merged, so he removed it to allow me to merge it; however, @bear101 told him to add a Change Log. Yet, there have been instances in the past where a PR was not merged even though everything, including the Change Log, was fine. I apologize to @bear101, but from his perspective, it likely felt like you are making excuses to avoid merging the PR. There were times when the code wasn't good, and I believe there should have been feedback or approval within at least three days.

[hwangsihu]

I am not fluent in English, so I used a translator; therefore, it may have sounded unpleasant or there may be parts that are incorrectly expressed.

[Nardol]

I understand that @amirmahdifard has contributed a lot to TeamTalk Android, and I do not want to dismiss that work. Contributions deserve recognition.

However, the way this discussion has been handled did not help either. Repeatedly pressuring people in comments, demanding to be added to the organization, or asking for a pull request to be reopened in that tone does not make the situation better. If someone wants to be taken seriously as a contributor, the attitude in project discussions matters too.

There was also feedback about correcting the numerous spelling mistakes. Of course we should be tolerant of non-native English speakers — I am not a native English speaker either — but this does not mean no effort should be made. Text written in pull requests, commit messages, changelogs, and project files remains part of the project history, so it is reasonable to expect contributors to take some care with it.

More generally, a maintainer is not obligated to accept every contribution, and contributing a lot does not automatically create a right to be added to the GitHub organization. Organization membership is a matter of trust, responsibility, and maintainers’ choice, not simply a reward based on the number of contributions.

At this point, the whole discussion is becoming unnecessarily exhausting and distracting from the project itself. I think everyone would benefit from keeping the discussion calmer, more professional, and focused on what is actually needed for the project.

[hwangsihu]

Yeah, you're right too.

Let's respect each other.

[amirmahdifard]

@Nardol your points are 100%, 200% 300% correct.
but, would you also listen to my point as well please? now that the conversation is about respecting each other?
As you even said, I contributed a lot. At first, I was contributing a lot, then I stopped for a while due to my cuntry state war etc, And Then I came back, Lets start from 2 months ago.
I opened around 9 or 10 prs at the first, and they all stayed open for weeks as you saw, and the owner didn't care. Then that @hwangsihu tested all my prs, and he also understood that my prs are working perfect, So I decided to remove the changelog, so he can merge my prs. See, from start of the joon that @hwangsihu started to merge my prs, See how many huge works I've done to teamtalk android? you will enjoy it when the new update is releaced. Typing indicaters for android, classroom controle actions, And now waiting to merge, pause and resume media files streams, Which is waiting for 2 days.
Do you know that if we wanted to wait for @bear101 to merge my prs, The point we are at now, we would reach in 2 years in that case. I even have a clear document to show you. See this pr. #3320
because @hwangsihu updated a library file in this pr, We need @bear101 to merge it. And as you can see the time of this pr, it says 3 weeks ago. It just adds 3 new options to channel prop. If we waited for @bear101 to merge my prs, We would reach no point at this time.
Now, I want to explane the reason why I'm constantly asking to merge my pr.
You only see the other side of the fence.
Emajin, you are coding for a project called teamtalk, that has very very annoying owner. You spend hours, figger out the best and clean and same stile code to implement a feature or fix a bug, Compile, Test, And send pull request. In that point, I get stress because I don't want my code, my time, my work to be lost. but sadly, @bear101 does not understand this. At the other side, First he told me to fix your commit messages, even though my code which is the actual stage is, was correct. But I said ok. I fixed my spelling mistakes. Then, he said update the changelog on the pr itself but doing that means @hwangsihu could no longer merge my pr and we needed to wait for @bear101 which takes years and months. So if you see my comments every hour, if you see that i'm asking too much, if you see that i'm worryed and stressed, It's because of this. It's because I have stress. For example now, my pr about pause and resume feature is still not merged, which I have stress for it until it gets merged. But others don't care about it because They didn't spend their time on it. I spent my time. I was the one coded for it. So if My pull request is not merged, it means all my work is lost. But it's seriously enough of these stress. I just want to manage my last 2 pr to be merged, and I will never work on this person's project. I had a lot of plans for it, But as long as @bear101 is owner of teamtalk, it is absolutely impossible to work on this project. He just does whatever he likes, without considering other people. As you said, atitude is also a part of contribution, which he doesn't have. For example, He ignors my comments. He ask others to test my changes in a way that I haven't tested my changes yet. He says several of amir's prs could be avoided if they had been tested properly. Etc. I really hope you read my message. I hope i'm talking to a reasonable person here that also understands my viewpoint as well. Thanks

[beqabeqa473]

Hello all.

Thank you for your contributions first of all.

That is great that you have time to do such things.

But you should also understand, that maintainers may not have enough time to react on your requests instanteniously.
They have their own lifes, work and so on.

If this contribution will be valuable, and i think most of them are, they will be accepted sooner or later.

And about adding users to organization, i am sure no one is doing that. If you will open even 100+ prs in nvda or some other non-solo project, no one will let you step in to an organization.

So, contributions are great, you are always welcome to make improvements, you are in contributors list. Please understand, that not every person, despite of opening prs can be added into an organization.

[amirmahdifard]

@beqabeqa473 hi! thanks for your comment. Well, even the problem is not about the time it takes for a pr to be merged. It's about how they reacted to the pr. And about contributors invitation, i wasn't simply thinking about whoever does moste contribution will be invited. My question is, what that is baced on. For example, I want to example you yourself. In your pr history, you have 17 merged prs. @hwangsihu mostely only upgrades and downgrades and plays around with the dependencys. But both of you have been invited and added. But Looking at my merged prs history, they are all codebace modify. Features and bug fixes for teamtalk android since 5.15. Up to today, i modifyed and refacktored the entire activitys of the app, with holding more than 50 merged prs in my history, even @bear101 yesterday admitted that just since the releace of 5.22 releace until now, I modifyed 3140 lines of teamtalk android code, only in this version. As i said, i proved myself before that I said i have the time and possibility to implement all the huge dialogs that we have in windows, but for now i'm avoiding it because of this state, there is no garantee that what will happen to my contribution. Feal free to answer. Thanks!