Add --branch-coverage flag to respect partial branch coverage#608
Merged
Conversation
diff-cover treated any executed line (hits > 0) as covered, ignoring Cobertura branch/condition-coverage data. A branch that was reached but only partially exercised therefore passed even --fail-under=100. Add an opt-in --branch-coverage flag that treats a partially covered branch (branch="true" with condition-coverage below 100%) as a violation. Default behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
Thanks for the pr! Ill get this out! |
Owner
|
Released! https://pypi.org/project/diff-cover/10.4.0/ thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
--branch-coverageflag.By default diff-cover treats any executed line as covered, so a partially exercised branch in a Cobertura
coverage.xmlpasses even at--fail-under=100. With the flag, a line withbranch="true"andcondition-coveragebelow 100% counts as uncovered. Default behaviour is unchanged; scope is Cobertura XML.Related: #182, #513