[action] [PR:853] Add timestamp to the leak sensor data in DB, Fix to not escalate a minor leak if platform doesn't support it#73
Merged
Conversation
…nor leak if platform doesn't support it
#### Description
Couple of enhancements/fixes in this PR
1. Add timestamp to the leak sensor data in DB
2. Fix to not escalate a minor leak if platform doesn't support it
Fixes sonic-net/sonic-buildimage#28218
3. Also update the leak_severity in sensor table to in DB correctly as 'CRITICAL' 'MINOR' and 'None' strings
#### Motivation and Context
If the platform doesn't support escalation of a minor leak --> critical Skip it by checking the return value of platform API is 0
Add timestamp to sensor leak data entry in sensor table -- This will help triage when the leak started.
#### How Has This Been Tested?
Unit tests added which mock the leak conditions and test
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### Additional Information (Optional)
Collaborator
Author
|
Original PR: sonic-net/sonic-platform-daemons#853 |
Collaborator
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Couple of enhancements/fixes in this PR
Add timestamp to the leak sensor data in DB
Fix to not escalate a minor leak if platform doesn't support it
Fixes Bug: BMC leak escalation logic is not aligned with the HLD sonic-net/sonic-buildimage#28218
Also update the leak_severity in sensor table to in DB correctly as 'CRITICAL' 'MINOR' and 'None' strings
Motivation and Context
If the platform doesn't support escalation of a minor leak --> critical Skip it by checking the return value of platform API is 0
Add timestamp to sensor leak data entry in sensor table -- This will help triage when the leak started.
How Has This Been Tested?
Unit tests added which mock the leak conditions and test
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
Additional Information (Optional)