-
Notifications
You must be signed in to change notification settings - Fork 2.2k
azure-ai-projects test re-recordings and alignment with Python on code customizations
#48504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpalvarezl
wants to merge
8
commits into
main
Choose a base branch
from
jpalvarezl/feature/test_recordings_projects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+521
−1,304
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2ca1782
Re-recorded and cleaned stuff
jpalvarezl f74b6d4
WIP
jpalvarezl 088b993
Python alignment for dataset ops
jpalvarezl 13a2c62
Name alignment
jpalvarezl c49f0f2
PR feedback
jpalvarezl b989125
Format problems
jpalvarezl 71a4efb
Right type of exception
jpalvarezl 60caf08
reverted docs
jpalvarezl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Java vs Python SDK — Custom Code Comparison | ||
|
|
||
| ## Datasets | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `upload_file` / `createDatasetWithFile` | ✅ Takes `connection_name` param | ✅ Takes `connectionName` param | ✅ Same | | ||
| | `upload_folder` / `createDatasetWithFolder` | ✅ Takes `connection_name` param, `file_pattern` regex filter | ✅ Takes `connectionName` param, no `file_pattern` | ⚠️ **Gap** — Java is missing `file_pattern`. Python lets you filter which files to upload via regex. | | ||
| | `list` / `listLatestVersion` | ✅ | ✅ | ✅ Same | | ||
| | `list_versions` / `listVersions` | ✅ | ✅ | ✅ Same | | ||
| | `get` / `getDatasetVersion` | ✅ | ✅ | ✅ Same | | ||
| | `delete` / `deleteVersion` | ✅ | ✅ | ✅ Same | | ||
| | `create_or_update` / `createOrUpdateVersion` | ✅ | ✅ | ✅ Same | | ||
| | `pending_upload` / `pendingUpload` | ✅ | ✅ | ✅ Same | | ||
| | `get_credentials` / `getCredentials` | ✅ | ✅ | ✅ Same | | ||
|
|
||
| ## Connections | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `list` / `listConnections` | ✅ | ✅ | ✅ Same | | ||
| | `get(name, include_credentials=)` | ✅ Single method with flag | ✅ `getConnection(name, includeCredentials)` | ✅ Same | | ||
| | `get_default(connection_type, include_credentials=)` | ✅ | ✅ `getDefaultConnection(connectionType, includeCredentials)` | ✅ Same | | ||
|
|
||
| ## Deployments | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `list` / `listDeployments` | ✅ | ✅ | ✅ Same | | ||
| | `get` / `getDeployment` | ✅ | ✅ | ✅ Same | | ||
|
|
||
| ## Indexes | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `list` / `listLatest` | ✅ | ✅ | ✅ Same | | ||
| | `list_versions` / `listVersions` | ✅ | ✅ | ✅ Same | | ||
| | `get` / `getVersion` | ✅ | ✅ | ✅ Same | | ||
| | `delete` / `deleteVersion` | ✅ | ✅ | ✅ Same | | ||
| | `create_or_update` / `createOrUpdateVersion` | ✅ | ✅ | ✅ Same | | ||
|
|
||
| ## Telemetry | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `telemetry.get_application_insights_connection_string()` | ✅ Custom sub-client | ❌ **Missing entirely** | 🔴 **Gap** — Python has a `TelemetryOperations` sub-client. Java has nothing. | | ||
|
|
||
| ## Memory Stores (Beta) | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `beta.memory_stores.search_memories()` | ✅ Custom patch with OpenAI `ResponseInputParam` support | ✅ Surfaced in `azure-ai-agents` SDK | ✅ Different SDK, not a gap | | ||
| | `beta.memory_stores.begin_update_memories()` | ✅ Custom LRO poller | ✅ Surfaced in `azure-ai-agents` SDK | ✅ Different SDK, not a gap | | ||
|
|
||
| ## Top-level Client | ||
|
|
||
| | Feature | Python | Java | Status | | ||
| |---|---|---|---| | ||
| | `get_openai_client()` | ✅ Returns `openai.OpenAI` with auth wired up | ✅ `buildOpenAIClient()` on the builder | ✅ Different pattern but equivalent | | ||
| | Console logging via `AZURE_AI_PROJECTS_CONSOLE_LOGGING` | ✅ | ❌ | Minor — nice-to-have | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"AssetsRepo":"Azure/azure-sdk-assets","AssetsRepoPrefixPath":"java","TagPrefix":"java/ai/azure-ai-projects","Tag": "java/ai/azure-ai-projects_de0a038f6e"} | ||
| {"AssetsRepo":"Azure/azure-sdk-assets","AssetsRepoPrefixPath":"java","TagPrefix":"java/ai/azure-ai-projects","Tag": "java/ai/azure-ai-projects_cd9e4bffa9"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.