azure-ai-projects test re-recordings and alignment with Python on code customizations#48504
Open
jpalvarezl wants to merge 8 commits intomainfrom
Open
azure-ai-projects test re-recordings and alignment with Python on code customizations#48504jpalvarezl wants to merge 8 commits intomainfrom
azure-ai-projects test re-recordings and alignment with Python on code customizations#48504jpalvarezl wants to merge 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates azure-ai-projects to align Java customizations and test coverage with the Python SDK, primarily around dataset upload behavior and connection management, while also re-enabling/reworking previously disabled tests and refreshing assets/metadata.
Changes:
- Added
connectionNamesupport to dataset upload helpers (file/folder) in sync and async clients. - Added
getDefaultConnection(connectionType, includeCredentials)to sync and async connections clients. - Reworked tests (including re-enabling) and updated assets + added a Python-vs-Java gap analysis doc.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/DatasetsClient.java | Adds connectionName overloads and refactors upload logic. |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/DatasetsAsyncClient.java | Adds connectionName overloads and refactors upload logic (reactive). |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/ConnectionsClient.java | Adds getDefaultConnection convenience API. |
| sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/ConnectionsAsyncClient.java | Adds async getDefaultConnection convenience API. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/ClientTestBase.java | Updates test proxy sanitization and logging options for tests. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/DatasetsClientTest.java | Reworks dataset tests; marks create/get/delete flows as LiveOnly and adds cleanup. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/DatasetsAsyncClientTest.java | Reworks async dataset tests; marks create/get/delete flows as LiveOnly and adds cleanup. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/ConnectionsClientTest.java | Reworks connection tests and adds coverage for default connection behavior. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/ConnectionsAsyncClientTest.java | Reworks async connection tests and adds coverage for default connection behavior. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/IndexesClientTest.java | Re-enables and refactors index tests to discover existing resources dynamically. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/IndexesAsyncClientTest.java | Re-enables and refactors async index tests; adds create/update + cleanup. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/DeploymentsClientTest.java | Re-enables deployments test class (removes Disabled). |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/DeploymentsAsyncClientTest.java | Re-enables async deployments test class (removes Disabled). |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/EvalsServiceTest.java | Removes flaky/disabled eval service test class. |
| sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/EvalServiceAsyncTest.java | Removes flaky/disabled async eval service test class. |
| sdk/ai/azure-ai-projects/src/samples/java/com/azure/ai/projects/TelemetrySample.java | Removes commented-out sample stub. |
| sdk/ai/azure-ai-projects/src/samples/java/com/azure/ai/projects/TelemetryAsyncSample.java | Removes commented-out sample stub. |
| sdk/ai/azure-ai-projects/src/samples/java/com/azure/ai/projects/InferenceOpenAISample.java | Removes commented-out sample stub. |
| sdk/ai/azure-ai-projects/src/samples/java/com/azure/ai/projects/EvaluationsSample.java | Removes commented-out sample stub. |
| sdk/ai/azure-ai-projects/src/samples/java/com/azure/ai/projects/EvaluationsAsyncSample.java | Removes commented-out sample stub. |
| sdk/ai/azure-ai-projects/assets.json | Updates asset tag reference. |
| sdk/ai/azure-ai-projects/PYTHON_GAPS.md | Adds documented gap analysis vs Python SDK custom code. |
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/ConnectionsAsyncClient.java
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/ClientTestBase.java
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/DatasetsAsyncClientTest.java
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/test/java/com/azure/ai/projects/IndexesAsyncClientTest.java
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/DatasetsClient.java
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/DatasetsClient.java
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/DatasetsAsyncClient.java
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/src/main/java/com/azure/ai/projects/ConnectionsClient.java
Show resolved
Hide resolved
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human summary
AI Summary
This pull request introduces several enhancements and API improvements to the Java SDK for Azure AI Projects, particularly around dataset creation and connection management. The main focus is on adding support for specifying a storage connection when uploading datasets (both files and folders), aligning the Java SDK more closely with the Python SDK, and introducing a new method for retrieving the default connection for a given type. Additionally, supporting documentation and metadata have been updated.
Key changes:
Dataset Upload Enhancements
connectionNameparameter tocreateDatasetWithFileandcreateDatasetWithFoldermethods in bothDatasetsClientandDatasetsAsyncClient, allowing users to specify which Azure Storage Account connection to use for uploads. This brings the Java SDK in line with the Python SDK's capabilities. [1] [2] [3] [4]Connection Management Improvements
getDefaultConnection(ConnectionType connectionType, boolean includeCredentials)in bothConnectionsClientandConnectionsAsyncClient. This method retrieves the default connection for a given type, mirroring the Python SDK's functionality. [1] [2]Documentation and Metadata
PYTHON_GAPS.md, providing a detailed comparison of features and gaps between the Python and Java SDKs for Azure AI Projects.assets.jsontag to reference the latest asset version.Dependency Updates
BlobContainerClientandBlobContainerAsyncClientwhere required for the new upload logic. [1] [2]