Make runRebootRemediation testable via dependency injection; add coverage#134
Draft
Copilot wants to merge 2 commits intorunzhen/npd3from
Draft
Make runRebootRemediation testable via dependency injection; add coverage#134Copilot wants to merge 2 commits intorunzhen/npd3from
Copilot wants to merge 2 commits intorunzhen/npd3from
Conversation
Co-authored-by: runzhen <32292691+runzhen@users.noreply.github.com> Agent-Logs-Url: https://github.com/Azure/AKSFlexNode/sessions/c9b7f2cd-a2e3-41b0-a177-ab46f6eaa9f3
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on node condition remediation PR
Make runRebootRemediation testable via dependency injection; add coverage
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runRebootRemediationhard-codedsystemd.New()andexec.CommandContextinternally, making it untestable without a live systemd. Addresses the review feedback on #131.Changes
pkg/drift/remediation.gorebootCommandRunnerfunc type for the exec dependencydefaultRebootRunnerwrappingexec.CommandContext(annotated#nosec G204)runRebootRemediationWithDeps(ctx, logger, mgr systemd.Manager, runner rebootCommandRunner)— the injectable, testable corerunRebootRemediationbecomes a one-liner wrapper providing the real deps:status→unitStatusto avoid shadowing thestatuspackagepkg/drift/remediation_test.gostubSystemdManager(fullsystemd.Managerimplementation) andstubRebootRunnertest doublesTestRunRebootRemediationWithDepswith 6 parallel subtests:unit-not-found/no-opErrUnitNotFound→ nil, runner not calledinactive/no-opactive/executes-rebootget-unit-status-error/surfacedErrUnitNotFounderror → wrapped and returnedreboot-command-fails/surfacedreboot-command-times-out/surfaced💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.