Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds “node reboot required” detection/remediation by surfacing a reboot-needed signal in the status snapshot, turning it into a drift finding, and introducing a reboot remediation action.
Changes:
- Extend
status.NodeStatuswith aNeedRebootflag and populate it during status collection by inspecting the node’sKernelDeadlockcondition. - Add a new drift detector (
RebootDetector) that emits a reboot finding whenNeedRebootis true. - Add a new drift remediation action (
reboot) that triggers a system reboot viasystemctl, plus unit tests for the detector.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/status/types.go | Adds NeedReboot to the persisted node status schema. |
| pkg/status/collector.go | Computes NeedReboot by reading boot time and querying node conditions. |
| pkg/drift/detector.go | Introduces RemediationActionReboot. |
| pkg/drift/defaults.go | Registers RebootDetector in default detector set. |
| pkg/drift/node_reboot.go | New detector that converts NeedReboot into a drift finding/remediation plan. |
| pkg/drift/node_reboot_test.go | Unit tests for reboot detector behavior. |
| pkg/drift/remediation.go | Adds reboot remediation runner that invokes systemctl reboot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.