TNG units#185
Merged
Merged
Conversation
… MAHs are in Msun
aphearin
approved these changes
May 5, 2026
Contributor
aphearin
left a comment
aphearin
left a comment
There was a problem hiding this comment.
Thanks for the clear explanation. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting the units of mass of halo MAHs for TNG, so that the output MAHs are in Msun.
The documentation in TNG specifies that the Subfind Subhalos$[10^{10} M_\odot/h]$ , while $[M_\odot/\text{yr}]$ .
SubhaloMasscolumn is in unitsSubhaloSFRis in unitsThe current loader assumes that our TNG halo masses are already in$[M_\odot]$ . However, when comparing the SFR-$M_0$ relation using TNG data corrected to the desired units of $[M_\odot]$ , we find a systematic bias along the x-axis. This indicates that our saved halo masses are still in $[M_\odot/h]$ , rather than $[M_\odot]$ .
Therefore, the loader should convert saved TNG halo masses to physical solar masses using:$M[M_\odot] = M_{\rm saved}[M_\odot/h] / h$ . This PR makes this change.