Tng correctunits#115
Conversation
…andatory FB parameter.
…fstarpop target data, to the new Diffstar params signature.
…its simulation data.
|
Just checking: is it necessary to re-run our optimizations in light of #116? Or is this unnecessary? Your call, just double-checking before this gets merged. |
|
We don’t need to re-run our optimizations for the results in the released paper. In the DiffstarPop paper, we decided to neglect satellite-specific quenching that depends on merger histories, leaving that for future work (and we discuss that somewhere in section 5). But as a result, the released |
aphearin
left a comment
There was a problem hiding this comment.
Looks ready to merge to me! Once you merge this in, we can do a new minor release of diffstar.
Correcting the units of mass of halo MAHs for TNG, so that the output MAHs are in Msun. For more details see diffmah PR#185
The main changes are: