Skip to content

Tools: install-ROS: rewrite for ROS 2 + Gazebo Garden - #34918

Open
igoutta wants to merge 2 commits into
ArduPilot:masterfrom
igoutta:fix-ros2
Open

igoutta wants to merge 2 commits into
ArduPilot:masterfrom
igoutta:fix-ros2

Conversation

@igoutta

@igoutta igoutta commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Since you asked for that fix, I did the closest thing.

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

Description

apt-key adv was removed in Ubuntu 24.04, so the current script fails on
every modern release. This rewrite:

  • Uses the modern signed-by keyring for packages.ros.org
  • Drops ROS 1 / focal (EOL; ardupilot_ros is ROS 2 only)
  • Picks ROS 2 distro from codename: jammy→humble, noble→jazzy,
    plucky→kilted, questing/resolute→rolling; -r DISTRO overrides
  • Same CLI shape as install-prereqs-{ubuntu,arch}.sh (-y -q -s -r),
    SUDO array (sudo/doas/run0), refuses to run under sudo
  • geographiclib script in mktemp, deleted after
  • rosdep init only when uninitialized (was || true)
  • colcon build instead of catkin
  • Guarded tput (no crash in CI)
  • No trailing source ~/.bashrc (no-op for parent shell)

Not yet run. bash -n clean. shellcheck not available locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant