Make compatible with ‘box’ 1.2.1#184
Merged
Merged
Conversation
In ‘box’ version 1.2.1, the return type of `box:::load_mod` has changed. This PR integrates that change into ‘box.linters’ while keeping it compatible with past versions.
radbasa
approved these changes
Nov 27, 2025
Comment on lines
+32
to
+33
| mod_ns <- if (utils::packageVersion("box") < "1.2.1") { | ||
| load_mod(info) |
Collaborator
There was a problem hiding this comment.
Tested locally with box@1.2.0, testthat@3.2.3
Comment on lines
+34
to
+36
| } else { | ||
| load_mod(info)$mod_ns | ||
| } |
Collaborator
There was a problem hiding this comment.
Untested. box@1.2.1 is not yet on CRAN.
Contributor
Author
There was a problem hiding this comment.
Oh, apologies! I had meant to link to the development build. As you probably saw from the email conversation, ‘box’ 1.2.1 will only be released on CRAN after ‘box.linters’ is updated to match.
You can test ‘box’ 1.2.1 locally by installing the dev build branch, e.g. via ‘pak’:
pak::pak('klmr/box@build')
Collaborator
There was a problem hiding this comment.
Tested with box@1.2.1
Confirmation that running with box@1.2.1 takes the new branch from {covr}:
BTW, @klmr , covr@3.6.5 recently went live. It now supports {box} via covr::file_coverage().
This was referenced Nov 27, 2025
jakubnowicki
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
‘box’ requires an update to fix CRAN issues due to changes to the R C API visibility.
These change have unfortunately required changes to the return type of
box:::load_mod. This PR integrates that change into ‘box.linters’ while keeping it compatible with past versions.R CMD check, linter, unit tests, spelling)..Rdfiles withroxygen2::roxygenise())