Skip to content

Fix issues from dev lintr#185

Merged
radbasa merged 1 commit into
Appsilon:mainfrom
MichaelChirico:lintr-msg-type
Dec 9, 2025
Merged

Fix issues from dev lintr#185
radbasa merged 1 commit into
Appsilon:mainfrom
MichaelChirico:lintr-msg-type

Conversation

@MichaelChirico

Copy link
Copy Markdown
Contributor

Thank you for using {lintr}!

The development version of lintr breaks {box.linters} in two ways:

  • We require the message component of Lint() objects to be a plain character, in particular, not a {glue} object.
  • The default pipe in the Tidyverse guide is now |>, not %>%, so code using %>% can newly lint: https://style.tidyverse.org/pipes.html#introduction

The latest release of {testthat} broke {lintr}, so I'll be releasing a breaking change in the near future, which this PR resolves.

@radbasa radbasa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle.

lintr@3.2.0, testthat@3.2.3
Screenshot 2025-11-27 at 3 20 57 PM

lintr@3.2.0, testthat@3.3.1
Screenshot 2025-11-27 at 3 22 42 PM

We will need to re-test when lintr gets updated.

@radbasa

radbasa commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

lintr@3.3.0.1 released last week.
box@1.2.1 released during the weekend.

This PR/branch fails because it does not yet have the fix from #184.

Screenshot 2025-12-01 at 7 35 08 PM Screenshot 2025-12-01 at 7 35 16 PM

Manually applying the fix from #184:

Screenshot 2025-12-01 at 7 39 23 PM

@radbasa radbasa merged commit edff284 into Appsilon:main Dec 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants