Fix unauthenticated astro-numerology Groq cost abuse and cache IDOR - #56
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Unauthenticated POSTs to /api/astro-numerology/analysis and /api/vedic-astro-numerology/analysis could burn Groq credits and read/write Admin cache under an attacker-chosen userId. Gate both routes on a matching Firebase token, generate in-process for the orchestrator, and send Bearer tokens from the tool tabs. Co-authored-by: Andy Oliver Rozario <andyrozario7@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
POST /api/astro-numerology/analysisandPOST /api/vedic-astro-numerology/analysis. Unauthenticated callers can no longer burn Groq credits or read/write another user's Admin cache.Why this change is safe
userIdwith no auth, then called Groq and Admin-backedusers/{userId}/...Reports/current.Verification
pnpm exec eslinton touched files (0 errors)pnpm test— 71 suites / 389 tests passedpnpm run securitypassedRegression prevention
tests/integration/astro-numerology-analysis-auth.test.tsandtests/integration/vedic-astro-numerology-analysis-auth.test.ts(401 missing/invalid token, 403 mismatched userId, 200 owned uid).Release checklist (solo-friendly)
CI / Lint + JestCI / Playwright smokemain.