Repository navigation
Fix snippet editing and screenshot clipboard preservation for 2.8.8 - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snippet token insertion now replaces the native selection or inserts at the caret, with document-scoped Undo/Redo and guarded callbacks when switching snippets. A hosted SwiftUI/AppKit regression and physical preview checks cover updates between documents; ordinary autosave preserves the caret.
Screenshot history derives pixel dimensions from the exported image. Screenshot copy snapshots the previous clipboard before clearing it and restores it after an injected write failure only while no newer external copy exists. A snapshot that exceeds existing safety bounds is rejected before mutation with an explicit file-export alternative.
Snippet rendering skips clipboard text reads for literal/date/escaped templates. Required reads run on the data queue with before/after generation checks. The separate main-thread rollback snapshot remains unchanged. Accessibility labels distinguish history filters and preview input.
Validation: strict debug 380 XCTest (8 explicit opt-in skips), 4 Swift Testing checks; site 14 tests/45 assertions and SEO 13/37; source/history secret scan passed. Physical isolated preview verified token selection, Unicode/multiline input, native Cmd+Z/Shift+Cmd+Z, autosave and document switching. Final optimized release, ASan and TSan each passed the same 380 XCTest (8 opt-in skips) and 4 Swift Testing checks. Required GitHub CI/CodeQL/Secret Scan must all pass before merge. Native pasteboard failure is covered by injection, not an observed OS failure.
Source candidate 2.8.8/build 54; public manifest remains at verified 2.8.7 until the new signed, notarized artifacts are published and independently downloaded.