Skip to content

fix: add keyboard accessibility to Learn More modal - #472

Draft
vivekrajputofficial29-afk wants to merge 1 commit into
AOSSIE-Org:mainfrom
vivekrajputofficial29-afk:fix/471-learnmore-modal-a11y
Draft

vivekrajputofficial29-afk wants to merge 1 commit into
AOSSIE-Org:mainfrom
vivekrajputofficial29-afk:fix/471-learnmore-modal-a11y

Conversation

@vivekrajputofficial29-afk

Copy link
Copy Markdown

Description

Fixes #471

The Learn More dialog looked modal but keyboard focus could move behind
the overlay, and Escape did not close it. This PR adds the missing
keyboard and screen reader behaviour to LearnModeModal.jsx.

Changes

  • Added role="dialog", aria-modal="true" and aria-labelledby (linked to the dialog title)
  • Focus moves into the dialog when it opens
  • Tab / Shift+Tab are trapped inside the dialog
  • Escape closes the dialog
  • Focus returns to the Learn More button when the dialog closes
  • Added aria-label="Close dialog" to the icon-only close button
  • Layout, styling and content are unchanged

How I tested

  • Opened Learn More without a PAT and checked: focus enters the dialog,
    Tab/Shift+Tab stay inside, Escape closes it, focus returns to Learn More
  • npm run build passes
  • No lint script exists in this repo, so lint was not run

Screenshots/Recordings:

Screen.Recording.2026-11-21.101405.mp4

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

Parsing warnings: 1

Validation error: Unrecognized key: "instructions" at "reviews"
Configuration instructions

  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added bug Something isn't working enhancement New feature or request frontend Frontend changes javascript JavaScript/TypeScript changes size/M 51-200 lines changed first-time-contributor First time contributor labels Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request first-time-contributor First time contributor frontend Frontend changes javascript JavaScript/TypeScript changes size/M 51-200 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Learn More analysis dialog allows focus behind the overlay and ignores Escape

1 participant