Repository navigation
Description
Bug Description
The Learn More dialog in the Standard Analysis banner looks modal, but keyboard focus remains on the page behind it. Pressing Tab after opening it moves to Connect PAT & Run underneath the overlay, and Escape does not close it.
In src/components/LearnModeModal.jsx, the dialog also has no dialog role or accessible name, and its icon-only close button is unnamed. The visible Close button does work; this report concerns modal keyboard behaviour, not a completely unclosable popup.
Expected: opening the dialog moves focus inside it, Tab/Shift+Tab stay within it, Escape closes it, and focus returns to Learn More when it closes.
Steps to Reproduce
- Without a PAT, explore an organisation and open Overview.
- Click Learn More in the Standard Analysis banner.
- Press Escape: the dialog remains open.
- Press Tab: focus moves to Connect PAT & Run behind the overlay.
- Inspect the accessibility tree: the overlay has no dialog role, and the top-right close icon has no accessible name.
Logs and Screenshots
The recording and screenshot use the real local app with synthetic GitHub API responses for an organisation labelled “Keyboard demo (local fixture)”. No real token was used. The modal component is unchanged from upstream main at b396d1b7f50a3341d4a5b9ff67211d95c9a5fb95.
Recording: opening Learn More, pressing Escape, then Tab:
learnmore-keyboard-before.webm
Screenshot after Tab: the focus outline is on Connect PAT & Run behind the dialog.
Three local Testing Library/jsdom diagnostic cases additionally reproduced missing dialog semantics, ignored Escape, focus escaping to a background control, and focus falling back to the document body after closing. These diagnose the current behaviour; no fix has been implemented yet.
Proposed contribution and coordination
I'd like to take this as my next contribution: add named dialog semantics, focus entry and containment, Escape handling, focus restoration and a name for the icon close button, with regression tests. I'd keep this scoped to LearnModeModal and its tests, preserving the current content and layout.
My PR #469 is still awaiting human review, so could a maintainer confirm whether this is a useful next task and when you'd prefer me to start under the one-issue-at-a-time guideline? Please also let me know if anyone is already working on it.
I checked existing issues and all 93 open PR file lists on 20 November; none changes LearnModeModal. Related #466 / #468 covers PAT-field labels, #363 / #364 covers page information controls, and #419 / #429 covers table headers.
AI assistance was used for the investigation, diagnostic tests and proposed approach.
Environment Details
- Windows; local Vite development build, React 18.
- Chromium-based browser via Playwright; no PAT.
- Diagnostic tests: Node 25.8.0, Vitest 4.1.10, jsdom.
- The recording uses mocked API data, not a live organisation analysis.
Impact
Medium - Feature works but has issues
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
Activity
vivekrajputofficial29-afk commentedon Nov 20, 2026
hey @Ri1tik
I'd like to contribute to this issue (#471) by implementing the keyboard accessibility improvements in
LearnModeModal.jsx, including focus management, focus trapping, Escape handling, focus restoration, and regression tests.My previous PR #470 is currently awaiting maintainer review. I wanted to check whether I can start working on this issue or should wait until my previous PR is reviewed/merged.
Please let me know. Thank you!
vivekrajputofficial29-afk commentedon Nov 21, 2026
Hi @Ri1tik, I've prepared a draft PR #472 for this issue. I'll mark it ready for review once #470 is merged (open PR limit). Happy to adjust based on feedback