Skip to content

fix(config): the built-in F1-F12 key symbols never match #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
844196 merged 1 commit into from
Sep 3, 2026
Merged

fix(config): the built-in F1-F12 key symbols never match #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions e2e/tests/07_render.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,20 @@ YAML
assert_line --index 1 ' ⏎ ➜ Enter'
}

@test "a built-in function key symbol resolves for a lowercase key" {
write_bindings <<'YAML'
- key: f1
type: command
desc: Help
buffer: man wk
YAML
start_wk_session
wait_for_screen 'Help'

run capture_screen
assert_line --index 1 ' 󱊫 ➜ Help'
}

@test "symbols.keys can be overridden from config" {
write_config <<'YAML'
symbols:
Expand Down
24 changes: 12 additions & 12 deletions src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,18 +146,18 @@ const DEFAULT_KEY_SYMBOLS: Record<string, string> = {
pagedown: '⇟',
insert: '⎀',
delete: '⌦',
F1: '󱊫',
F2: '󱊬',
F3: '󱊭',
F4: '󱊮',
F5: '󱊯',
F6: '󱊰',
F7: '󱊱',
F8: '󱊲',
F9: '󱊳',
F10: '󱊴',
F11: '󱊵',
F12: '󱊶',
f1: '󱊫',
Comment thread
844196 marked this conversation as resolved.
f2: '󱊬',
f3: '󱊭',
f4: '󱊮',
f5: '󱊯',
f6: '󱊰',
f7: '󱊱',
f8: '󱊲',
f9: '󱊳',
f10: '󱊴',
f11: '󱊵',
f12: '󱊶',
}

export const ContextSchema = z.looseObject({
Expand Down