fix(config): the built-in F1-F12 key symbols never match - #66
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The fallback incorrectly makes symbol lookup case-insensitive, and the regression lacks test coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes function-key glyph rendering by aligning built-in symbols with Cliffy’s lowercase key names.
Changes:
- Renames F1–F12 symbol keys to lowercase.
- Adds a lowercase fallback during symbol lookup.
File summaries
| File | Description |
|---|---|
src/schema.ts |
Corrects built-in function-key names. |
src/ui.ts |
Adds lowercase symbol lookup fallback. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…-case names @cliffy/keycode reports function keys as "f1"-"f12", but DEFAULT_KEY_SYMBOLS spelled them "F1"-"F12", so the lookup in getKeySymbol always missed and fell back to the raw key name. Renamed the twelve entries to lower case to match, and added an e2e regression test asserting a lowercase-keyed binding (e.g. `key: f1`) renders its built-in glyph, so a reintroduced casing mismatch fails the suite instead of only being caught by eye. Closes #65 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
844196
force-pushed
the
844196/main/fix-65
branch
from
September 3, 2026 14:05
188de45 to
799f813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cliffy/keycodereports function keys as lower-casef1-f12, butDEFAULT_KEY_SYMBOLSinsrc/schema.tsspelled them upper-caseF1-F12.getKeySymbollooked up the reported key name directly, sothe lookup always missed and fell back to rendering the raw key name
(
f1) instead of the Nerd Font glyph.Fixes #65.