Repository navigation
feat(opencode): harden dual observer lifecycle and native provenance - #382
Merged
Merged
Conversation
Preserve published root factories while sharing one V2 reducer with the strict native reader. Retain actual ingress and terminal identities, bound lookup and preparation lifetimes, and synchronously cancel full-capacity native controls. Package the unpublished 0.3.0 candidate with genuine installed consumer checks.
Merge the original PR #373 history after adapting its published root contracts into the independently reviewed 0.3.0 candidate. The resulting tree is byte-identical to the tested candidate; one shared V2 reducer replaces the obsolete standalone engine.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (26)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 61.77% 61.77%
=======================================
Files 1438 1438
Lines 76189 76213 +24
=======================================
+ Hits 47066 47081 +15
- Misses 22614 22620 +6
- Partials 6509 6512 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Preserve both current VS Code Local APIs and the OpenCode native provenance decoder. Refs 777genius/agent-notifications#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode notification consumers need original native provenance, cancellation before delayed delivery and a bounded reader lifecycle. This change preserves the public root V1/V2 factories and types, shares the V2 reducer with the strict native subpath, and keeps active turns across legitimate native session touches. Unknown or cancelling lifecycle updates still invalidate pending delivery synchronously.
Validation on exact head
01f7fced8098a1341da7fb4cafa9268b5798c3f7: all 38 check runs and the additional review status succeeded; 148 SDK tests passed with no skips, pinned TypeScript and public installed import/type/behavior checks passed for V1 floor/current and V2-only with no V1 peer. Genuine immutable unpublished npm-pack bytes remain SHA256c3d5aaaf6ecc3116b48ab1ae3f0e00b47720f239df9938f0c499d03f2c21a752. Independent GPT-6.1 high source and current-head readiness review accepted the bounded SDK change.Preserve the original PR #373 commits and the meaningful provenance checkpoints with a merge commit. The three newer main commits modify disjoint source paths. This SDK checkpoint does not claim final installed Agent Notifications qualification and does not publish an npm package or release.
Refs 777genius/agent-notifications#105
777genius/agent-notifications#105