Repository navigation
feat(opencode): bind installation to the selected native host - #381
Merged
Merged
Conversation
Private continuation seed after hosted model capacity failure. Native generic capability facts are frozen; observer capabilities remain unverified. Lifecycle authority and behavior tests follow before any mergeability claim.
Resolve version capabilities and native configuration dialect through one shared profile. Probe the explicitly selected executable at prepare/apply boundaries and fence changed image or symlink identities, including empty updates that clean prior native effects. Preserve generic skills and MCP installation independently of observer eligibility.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (35)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep the approved identity when a caller omits InstallationID in single and group requests. Committed hooks, public result and inspected binding now refer to the same installation and data receipt.
Merge the current SDK, physical profile and delivery confirmation changes without replacing existing OpenCode history. Reject mutating OpenCode groups before effects until per-target host snapshots exist; preserve single-host installation and stored removal. Fix the checked native path separator conversion and refresh the audited authoring source fingerprint. Independent GPT-6.1 high source and formatter reviews accepted the exact tree. Full current-head CI and final installed notification evidence remain pending. Refs 777genius/agent-notifications#105
Preserve separator and transport semantics while using current Go loop, context and string idioms required by the actual CI checks. Keep native authority, group refusal, lifecycle limits and source fingerprint unchanged. Refs 777genius/agent-notifications#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing OpenCode components must target the explicitly selected native executable and its matching configuration dialect. This change adds a shared version/capability profile, bounded prepare/apply probes and exact planned-image/symlink revalidation before native effects. Empty updates clean prior native components; stored remove/recovery remains independent of executable availability.
The integrated candidate
0231b685209f1d04f4cbd0565d64fe3c9b804c15preserves both original PR history and current maincd97ea0893a9430433db479cd0f5997f449ed1b7, including SDK #382 and physical profile/delivery confirmation changes. Independent GPT-6.1 high review accepted the exact source and mechanical formatter delta. It also found and fixed a group interaction: mutating groups containing OpenCode are refused before snapshots/effects until per-target host snapshots exist. Single OpenCode installation, other registered groups and stored group removal remain supported.The candidate fixes the checked path-separator conversion flagged by gosec and updates the authenticated authoring source fingerprint. The lint followup briefly introduced a map-key/slice-index compiler error, detected on Linux, macOS and Windows before native execution. An independently reviewed three-line append correction preserves nil, duplicates and sorted transport values. Fresh hosted compilation of clients/installer/clientdetect and the repository-configured changed-line lint both passed before publication. The full architecture lint stage also required two contiguous helper extractions. Independent GPT-6.1 high review accepted their preserved execution/error/authority semantics and the receiver-only naming correction. Four existing behavior tests and both verbatim CI lint commands passed on the reviewed source before publication. All 53 current-head check runs passed before the history-preserving merge. Independent GPT-6.1 high review supplied technical acceptance. The optional CodeRabbit status previously reported a draft review skip, then started a rescan when the PR became ready; it was not used as an independent review approval. Previous failures remain historical.
Retained predecessor evidence: the actual Linux V1 1.18.33/1.18.34 JSON/JSONC public installer matrix passed install/update/remove with real stdio/HTTP MCP tools, preserving foreign config/comments/files/skills; 16 deterministic provider requests, 8 tool calls and zero removal host probes. This remains bound to its tested predecessor. Native V2 notification admission and final Agent Notifications installed qualification are separate checkpoints.
The coherent authority/cleanup/prepare tests exceed the approximate 2,000-line review target; the final main-based delta is 35 files, approximately 2,539 additions and 60 removals. No package or release is published.
Refs 777genius/agent-notifications#105
777genius/agent-notifications#105
Summary by CodeRabbit