Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCore loss includes a microbatch multiplier that direct prefix backward must not inherit. Extract the unchanged logical RLTT objective, keep the old MCore adapter's scaling, and apply optimizer scaling once to suffix losses before injecting their already-scaled boundary adjoints.
Add an Ouro logical-step plan over actual iterator indices, preserving sample/GRPO group identity and global token/response weights across prompt grouping and suffix waves. Native rollout transport carries the original group IDs. This provides B1/B2 components; it does not yet replace the real learner schedule.
Stacked on #23 (
test/native-qualification-chain). Validation: 170 CPU tests pass, including 12 FP32 two-update cases against independent dense and actual MCore loss/backward functions. Maximum gradient relative L2 is 5.38e-7; maximum parameter-delta error is 1.20e-7. Twelve CPU BF16 cases remain strict expected numerical failures under unchanged tolerances; all 24 BF16 update deltas and six later gradients fail qualification. Full DDP/optimizer-wrapper and CUDA validation remain open.docs/rltt_logical_step.mdprovides numerical and required-speedup tables. Raw logs/XML, both-update measurements, retained failures and hashes are inbenchmarks/results/rltt-logical-step/. No GPU speed, memory reduction or reward-convergence claim is made.