Repository navigation
Conversation
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit
--rltt-prefix-wave-sizeroute to the actual MCore learner step. It creates each prompt prefix through DDP forward, accumulates packed suffix and prefix gradients in the existing buffers, finalizes once, and leaves optimizer/scheduler/publication/checkpoint ownership in the existing flow. The iterator advances only after the prefix update succeeds. The default remains the ordinary MCore schedule.Stacked on #24 (
feat/rltt-logical-step). The candidate is limited to one actual learner rank, FP32 Ouro RLTT, eager execution and unsharded non-overlapped gradients. Mixed precision and joint prefix rematerialization are not enabled.Validation: broad regression has 195 CPU passes, 2 CUDA skips and the 12 known BF16 numerical failures; a final focused run after guard/fixture review has 25 passes and 2 CUDA skips. These runs overlap. Provider entry gradients match exactly, native argument checks pass, and raw logs/XML plus hashes are retained in
benchmarks/results/rltt-prefix-schedule/.The prepared CUDA test calls actual MCore DDP, FP32Optimizer/AdamW, scheduler and
train_one_stepfor two updates, capturing finalized gradients and checking moments/cursor/cleanup. It has not executed: the full requested environment and device window are still pending.docs/rltt_prefix_schedule.mdrecords scope and comparison tables. Official-model learner qualification, GPU speed/memory and reward convergence remain open; this draft does not complete B.