Repository navigation
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Contributor
Author
|
Staging image published and registry-verified from PR head |
Co-authored-by: Codex <codex@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
M144 already supports continual gathering and legacy re-nomination, but the controlled ICE-lite side did not understand authenticated NOMINATION attributes. During a path change, the client therefore had to wait for media failure detection and perform an ICE restart, which made the Reconnecting audio banner visible. The experiment proves the same peer connection can move between candidate pairs without replacing ICE, DTLS, SRTP, RTP timelines, or SSRCs.
The synthetic hard-blackhole gap is still too long to call seamless, so the capability is off by default until real iOS and Android staging measurements pass. Disabling legacy_ice_renomination immediately restores baseline negotiation.
Dependency
Pinned fork commit: https://github.com/zyno-io/str0m/commit/750888c45c338bcbad64c51f009417b0bf459bd1
Checks
Staging
Current audited image: ghcr.io/zyno-io/rtpbridge@sha256:2a6f8d29e640d7dbab277bc5e23c0a72a1138177b837e754333d1ec908ece32a (head 39e2c79).
After the docker-push-pr check succeeds, deploy ghcr.io/zyno-io/rtpbridge:pr- and add --legacy-ice-renomination to the container arguments. The standard image excludes the experiment-only path fault injector.