Fix/comprehensive sync improvements#10
Merged
Merged
Conversation
Major fixes for vacuum command and CLI sync functionality: Vacuum Command Fixes: - Fix VacuumResult class to have proper __init__ method - Fix CLI client detection in vacuum_configs to check for 'cli:' prefix - Improve conflict resolution logic to handle CLI clients properly CLI Sync Fixes: - Fix CLI client detection in sync operations - Fix command format for Claude CLI to use proper '--' separator - Fix dry-run mode to properly record updated locations - Fix command comparison logic to normalize different formats - Add proper handling for URL-based servers (skip for CLI clients) CLI Command Fixes: - Fix add-server argument parsing to handle space-separated args - Improve args parsing logic to support both comma and space separation Diff Command Fixes: - Fix CLI conflicts to include required 'current' and 'master' fields - Fix location filtering to find locations by name in addition to path All sync functionality now works correctly with proper change detection and no false positives. Claude Code MCP servers now connect properly with correct command formats and environment variables.
- Add comprehensive test coverage for refactored config system - Create test_config_models.py with 51 tests for Pydantic models - Create test_settings.py with 47 tests for Settings class - Update all existing tests for new config architecture - Fix critical sync.py bug: use model_dump() for Pydantic serialization - Enhance scan/vacuum with auto-discovery of MCP clients - Update help text for space-separated argument format - Add client management infrastructure (executor, repository) - Total: 134 tests passing with comprehensive coverage
- Add noqa comments for subprocess security warnings (S603) - Fix line length violations (E501) by breaking long lines - Add noqa comment for mixedCase field name (N815) in GlobalConfig.mcpServers - Remove whitespace from blank lines (W293) - All tests passing, ready for CI
- Run ruff format to fix formatting violations - All linting and formatting checks should now pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.