Conversation
The stop() method apparently detaches the underlying device handle, which causes a noticeable delay on the GUI thread when stopping a repeating sound effect.
Easier now that SDL isn't required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Warning: Work in progress)
This changes tworld2 to use QtMultimedia instead of SDL for sound effect playback. This makes porting to other platforms easier, and reduces the number of dependencies needed for building tworld2. Note that this does not affect
OSHW=sdl(tworld 1) builds.Current known issues
loopCountproperty of QSoundEffect will cause playback of a looping sound will continue for one loop longer than necessary (most noticeable when exiting ice). It's possible to stop it earlier withQSoundEffect::stop(), but this causes the underlying audio device to detach from the sound system, which (at least on Windows) causes a hang of ~500ms on the GUI thread, which is unacceptable.