Fix lazy put calls - #289
Open
1000TurquoisePogs wants to merge 1 commit into
Open
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atlasPut in WebContent/js/utilities/urlUtils.ts decided whether to send a request as application/json (a z/OSMF utility request, e.g. rename or submit job) or text/plain (a raw dataset write) by substring-scanning the outgoing request body.
This is fragile way to separate 2 unrelated api calls that can break if the file contents contain json that looks like the json-type calls.
To avoid such a bug, I separated the 1 function into 2, and use types to further guard against developer mistakes