Removed bogus dev url - #288
Open
1000TurquoisePogs wants to merge 1 commit into
Open
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whichServer() in each explorer's urlUtils.ts contained dead test scaffolding for a bogus domain.
Removed the hardcoded tester.test.com branch from whichServer() in WebContent/js/utilities/urlUtils.ts.
Inlined the remaining trivial logic (location.host / global.location.host) directly at each call site in urlUtils.ts and actions/validation.ts, and dropped the now-unused whichServer export/import since it no longer did anything beyond a plain property read.
Updated the global.location test mock (tests/.../testDependencies.ts) to explicitly set host, since it previously only worked because of the special-cased production code being removed.
Replaced the test-fixture domain tester.test.com with tester.example.com (RFC 2606 reserved, non-registrable) in hostConstants.ts and mock fixture data, so no reference to a real, registrable domain remains anywhere in the codebase.
Testing: No behavioral change for real deployments — location.host/global.location.host is used exactly as before for all non-test hosts. Unit test mocks updated to match.