updating the eslint and updating the code

[AdarshdeepCheema]

Updated the eslint and fixed the code to meet the new rules
removed the --legacy-peer-deps from Dockerfile and changed RUN npm ci --legacy-peer-deps --no-audit --ignore-scripts \ to npm ci --no-audit --ignore-scripts \

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

PR Type

• Bug fix
• Feature
• Other (Please indicate)

PR Checklist

• PR completes npm run preCommit without error
• Relevant Test cases have been added (Unit and or FVT)
• Relevant update to CHANGELOG.md
• PR from forked repo? Ensure Allow edits by maintaners is set.

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/code_scan.yml:run-code-ql. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

4.2% Coverage
0.0% Duplication