fix integration test transmits z/OS credentials over cleartext HTTP - #58
Draft
js665999 wants to merge 1 commit into
Draft
fix integration test transmits z/OS credentials over cleartext HTTP#58js665999 wants to merge 1 commit into
js665999 wants to merge 1 commit into
Conversation
js665999
commented
Aug 27, 2026
- Default scheme changed from hardcoded http:// to https://, configurable via a new ZSS_PROTOCOL env var if someone genuinely needs cleartext for local-only testing (not recommended, but not silently forced away from them either).
- Added an httpsAgent to the shared axios instance so it works against a typical z/OS test ZSS with a self-signed certificate — but rejectUnauthorized defaults to true (secure), and only relaxes if the developer explicitly sets ZSS_ALLOW_SELF_SIGNED=true. Commented inline that it should never be used against a non-test endpoint.
- Since every request in the suite goes through the single instance (confirmed via grep — no bare axios.get() calls bypassing it), this covers all endpoints, including the ones that override baseURL per-call (gettcpipname, the malformed-tcpip-name cases, etc.).
Signed-off-by: js665999 <js665999@broadcom.com>
Member
|
Looks good to me so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.