Skip to content

fix integration test transmits z/OS credentials over cleartext HTTP - #58

Draft
js665999 wants to merge 1 commit into
v3.x/masterfrom
users/js665999/fix-test-cleartext-creds
Draft

fix integration test transmits z/OS credentials over cleartext HTTP#58
js665999 wants to merge 1 commit into
v3.x/masterfrom
users/js665999/fix-test-cleartext-creds

Conversation

@js665999

Copy link
Copy Markdown
  • Default scheme changed from hardcoded http:// to https://, configurable via a new ZSS_PROTOCOL env var if someone genuinely needs cleartext for local-only testing (not recommended, but not silently forced away from them either).
  • Added an httpsAgent to the shared axios instance so it works against a typical z/OS test ZSS with a self-signed certificate — but rejectUnauthorized defaults to true (secure), and only relaxes if the developer explicitly sets ZSS_ALLOW_SELF_SIGNED=true. Commented inline that it should never be used against a non-test endpoint.
  • Since every request in the suite goes through the single instance (confirmed via grep — no bare axios.get() calls bypassing it), this covers all endpoints, including the ones that override baseURL per-call (gettcpipname, the malformed-tcpip-name cases, etc.).

Signed-off-by: js665999 <js665999@broadcom.com>
@1000TurquoisePogs

Copy link
Copy Markdown
Member

Looks good to me so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants