Skip to content

Fix log injection via unsanitized query-string filter values - #55

Merged
1000TurquoisePogs merged 4 commits into
v3.x/masterfrom
users/js665999/fix-log-injection
Aug 28, 2026
Merged

Fix log injection via unsanitized query-string filter values#55
1000TurquoisePogs merged 4 commits into
v3.x/masterfrom
users/js665999/fix-log-injection

Conversation

@js665999

Copy link
Copy Markdown

Added a sanitizeForLog() helper that copies a string into a fixed-size buffer while stripping control characters (bytes < 0x20 and 0x7F), including CR/LF

js665999 added 2 commits August 19, 2026 10:24
Signed-off-by: js665999 <js665999@broadcom.com>
Signed-off-by: js665999 <js665999@broadcom.com>
Signed-off-by: js665999 <js665999@broadcom.com>
Comment thread dataService/src/ipExplorerDataService.c
Comment thread dataService/src/ipExplorerDataService.c Outdated
Signed-off-by: js665999 <js665999@broadcom.com>
@github-project-automation github-project-automation Bot moved this from Ready for Review to Merge Ready in WebUI planning board Aug 25, 2026
@js665999
js665999 marked this pull request as ready for review August 27, 2026 10:50

@1000TurquoisePogs 1000TurquoisePogs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anyhting thats going to go above 256 here, so thats ok.
Looks like if something does go above 256 it gets cut off, though

@1000TurquoisePogs
1000TurquoisePogs merged commit ef0f0fd into v3.x/master Aug 28, 2026
6 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Merge Ready to Closed in WebUI planning board Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants