Conversation
Add Stencil: 8 bits in the project
- Added a stencil test toggle to `StencilTestingActivity` and updated `ControlPanelContent` to support dynamic titles. - Implemented `stenciltest_event` handling in `StencilTestingScene` to receive state changes from the UI. - Updated native rendering logic to conditionally enable `GL_STENCIL_TEST` and render object outlines based on the toggle state.
Added Compose-based dropdown selectors and toggles to `BlendingActivity` to allow real-time adjustment of OpenGL blending parameters. This includes support for modifying source/destination factors and blend equations. Key changes: - **UI:** Introduced `SelectorControlPanelContent` using Material3 `ExposedDropdownMenuBox` to manage blending factors and equations. - **Native:** Implemented event parsing in `BlendingScene` to handle dynamic updates from the UI and apply `glBlendFunc` and `glBlendEquation` during the draw cycle. - **Scene Cleanup:** Refactored vertex data for better readability, enabled `GL_CULL_FACE`, and updated asset paths for shaders and textures. - **Shaders:** Renamed blending shaders for consistency and performed minor cleanup of float literals in tessellation shaders.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bbf0017e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Simplified shader filenames for CubemapScene and GeometryShaderScene by removing numeric prefixes and updated the corresponding C++ source files to use the new paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.