Repository navigation
Conversation
Once calibrationd has saved a calibrated CalibrationParams, the link's hello sends the wide road camera's rotation from the device and the camera's height (`camera`: wide_from_device_euler, height), read once a link, for server-side code that needs to place what the cameras saw. An optional adapter method, camera_calibration(), reads it; Stock's works for upstream's liveCalibration and a fork's extrinsicsCalibration. A server that predates the key ignores it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ernestchu
added a commit
to ernestchu/zoompilot
that referenced
this pull request
Nov 3, 2026
…mpilot/jetlink#21) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Hi, could you share what this is needed for? @ernestchu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a plugin to jetlink that needs the comma's camera calibration on the server side.
Once calibrationd has a calibrated
CalibrationParams, the hello now carries:It's read once per link and omitted until the comma is calibrated. A server that predates the key ignores it.
ModelSide.camera_calibration()is a new optional adapter method.link.pyreads it withgetattr, so adapters without it are unaffected.Stock.camera_calibration()readsCalibrationParams. It handles upstream'sliveCalibrationand a fork'sextrinsicsCalibration(zoompilot's), and never raises.JetlinkClient.hello(camera=...), plus a note indocs/link-protocol.md.Overhead: negligible. The work happens once per link, when the comma connects, and never per frame. Reading and decoding
CalibrationParamstakes about 16 µs (measured on x86, well under 1 ms on a comma). No new imports:openpilot.cereal.logis already loaded in modeld. The hello grows by 119 bytes, once per connection.🤖 Generated with Claude Code