Conversation
…ted YAML files - Deleted replication-factor.yaml and topic-replication.yaml as they are no longer needed. - Updated entrypoint.sh to include a function for revoking schema privileges. - Modified stackctl deployment process to reject direct deployment in favor of GitOps. - Added checks for various configurations in check-gitops.py to enforce best practices. - Created Kustomization files for all components to standardize deployment configurations. - Added identity hostname ConfigMaps for dev and prod environments to ensure proper configuration. - Updated stack.yaml to reference new Kustomization paths for components.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (38)
📝 WalkthroughWalkthroughThe pull request migrates Stackctl components from Helm paths to Kustomize sources. It routes deployment through Argo CD, adds rendered-manifest validation, updates environment overlays, and adds regression checks. It also adds dynamic schema privilege revocation. ChangesGitOps migration
Schema privilege cleanup
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Stackctl
participant Kustomize
participant ArgoCD
participant Cluster
Stackctl->>Kustomize: render overlays during dry run
Kustomize-->>Stackctl: return rendered manifests
Stackctl-->>ArgoCD: reject direct live deployment
ArgoCD->>Cluster: reconcile desired manifests
Possibly related PRs
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
GitHub-hosted CI remains unavailable because of the account billing lock; local repository checks passed.
Summary by CodeRabbit
New Features
Bug Fixes
Deployment
Documentation