Repository navigation
fix: bind child reservations and verify transaction memos - #159
Merged
Merged
Conversation
mellowcroc
added this pull request to stack #156
October 2, 2026 07:30
mellowcroc
force-pushed
the
fix/sca-event-memo
branch
from
October 2, 2026 07:39
fed52ef to
d953cfe
Compare
mellowcroc
force-pushed
the
fix/sca-event-memo
branch
from
October 2, 2026 08:08
d953cfe to
f64c13f
Compare
graikos
previously approved these changes
Oct 2, 2026
mellowcroc
force-pushed
the
fix/sca-event-memo
branch
2 times, most recently
from
October 2, 2026 09:31
fb3692b to
4e603f5
Compare
mellowcroc
force-pushed
the
fix/sca-event-memo
branch
from
October 2, 2026 09:45
4e603f5 to
25e39d3
Compare
graikos
approved these changes
Oct 2, 2026
mellowcroc
force-pushed
the
fix/sca-event-memo
branch
from
October 2, 2026 11:49
25e39d3 to
8af9f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
Addresses F-2026-19054 and F-2026-19134.
proposalHashas a caller-supplied label. Read the reservation for the child account and compare its reconstructed configuration hash with the parent's approved proposal data before setup; reject malformed or ambiguous owner events.This PR targets #158 (
fix/sca-token-id) and is the top of stack #156. Offline request/response format remains v1.Validation and limits
On the rebased full local stack: contracts build; 153 focused contract tests, 13 UI tests, 27 offline CLI tests, and 5 E2E unit tests passed. Contract and CLI tests used
SKIP_PROOFS=1. The SCA patches were unchanged by the rebase. The complete offline real-proof end-to-end run and hosted stack checks remain pending before merge. No deployment or release is included.